summaryrefslogtreecommitdiffstats
path: root/src/usr/expaccess/test/exptest_utils.H
diff options
context:
space:
mode:
authorChristian Geddes <crgeddes@us.ibm.com>2019-08-12 15:59:36 -0500
committerDaniel M Crowell <dcrowell@us.ibm.com>2019-08-13 15:12:15 -0500
commitc98af339b789ba503cde31038d449b73f4774b40 (patch)
treec637ee5b8fab25b6aa207df5c78965668204f936 /src/usr/expaccess/test/exptest_utils.H
parent3c930cf140f925293af0ce5c28e7e3b13c75d0e7 (diff)
downloadtalos-hostboot-c98af339b789ba503cde31038d449b73f4774b40.tar.gz
talos-hostboot-c98af339b789ba503cde31038d449b73f4774b40.zip
Do not unload modules loaded for unit tests
For some of the unit tests we must load in .so modules that were unloaded during the boot. Modules must get loaded and unloaded during the boot, especially before we expand from cache containment to over come size limitations. We were seeing issues were test case A and B both relied on a module and attempted to load it when the test case was instantiated then tried to unload the module when the test case was completed. This was causing issues if two tests were using the same loaded module and one test finished early and unloaded it. Test cases are run on simics after memory is expanded so there is no reason unload the extra modules we load in so we will leave them loaded. Change-Id: Ia41d38da11400f54ee2e59e497b9610ac24f1629 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82099 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/expaccess/test/exptest_utils.H')
-rw-r--r--src/usr/expaccess/test/exptest_utils.H11
1 files changed, 1 insertions, 10 deletions
diff --git a/src/usr/expaccess/test/exptest_utils.H b/src/usr/expaccess/test/exptest_utils.H
index ce0f5fe0d..a62b4de71 100644
--- a/src/usr/expaccess/test/exptest_utils.H
+++ b/src/usr/expaccess/test/exptest_utils.H
@@ -37,19 +37,10 @@ const char MSS_LIBRARY_NAME[17] = "libisteps_mss.so";
/**
* @brief Generic function to load a module
- * @param o_module_loaded - returns true if module is loaded by this function
* @param i_modName - module name to load
* @return error handle if module_load call fails
*/
-errlHndl_t loadModule(bool & o_module_loaded, const char * i_modName);
-
-/**
- * @brief Generic function to unload a module
- * @param i_modName - module name to load
- * @return error handle if module_unload call fails
- *
- */
-errlHndl_t unloadModule(const char * i_modName);
+errlHndl_t loadModule(const char * i_modName);
/**
* @brief Get the mutex pointer for syncronizing tests
OpenPOWER on IntegriCloud