diff options
author | Corey Swenson <cswenson@us.ibm.com> | 2018-10-18 16:50:35 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-10-26 12:23:04 -0500 |
commit | 5656a872211db5995d4205157bb38f733c5c18b7 (patch) | |
tree | 7508d857059984967cf4971b78312db475f0df9a /src/usr/errl | |
parent | 7637f0a444279a77e0ca1f34aeb3362e42356a94 (diff) | |
download | talos-hostboot-5656a872211db5995d4205157bb38f733c5c18b7.tar.gz talos-hostboot-5656a872211db5995d4205157bb38f733c5c18b7.zip |
Check for targeting before adding version info in errl commit
addVersionInfo function calls spBaseServicesEnabled, which
accesses targeting data. Moved the function call after the
check for targeting loaded.
Change-Id: Iaee25d71ce046821b7805f9fdb5a80bfa452f3fe
CQ:SW449232
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67730
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/errl')
-rw-r--r-- | src/usr/errl/errlentry.C | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/usr/errl/errlentry.C b/src/usr/errl/errlentry.C index 072a31ac1..ad95bc4dd 100644 --- a/src/usr/errl/errlentry.C +++ b/src/usr/errl/errlentry.C @@ -1000,9 +1000,6 @@ void ErrlEntry::commit( compId_t i_committerComponent ) // Add the Hostboot Build ID to the error log addHbBuildId(); - // Add the version info to the error log for OpenPOWER systems - addVersionInfo(); - // check to see if we should skip info and recoverable errors? checkHiddenLogsEnable(); @@ -1010,6 +1007,9 @@ void ErrlEntry::commit( compId_t i_committerComponent ) // serial numbers if(Util::isTargetingLoaded() && TARGETING::targetService().isInitialized()) { + // Add the version info to the error log for OpenPOWER systems + addVersionInfo(); + // If this error was a hardware callout, add the serial and part numbers // to the log. FSP provides this data so if there is no FSP, get them here. if(!INITSERVICE::spBaseServicesEnabled()) |