diff options
| author | Prachi Gupta <pragupta@us.ibm.com> | 2017-07-20 16:10:45 -0500 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2017-07-22 14:26:06 -0400 |
| commit | 708a0da84a9131aa362e4647b009678d0c58ea78 (patch) | |
| tree | 2e2b49e2c4f4d9ca893228a29ffc0aa05d7e6402 /src/usr/diag | |
| parent | c964a864cd5954e251a00271a12fe71b9d7dc9f0 (diff) | |
| download | talos-hostboot-708a0da84a9131aa362e4647b009678d0c58ea78.tar.gz talos-hostboot-708a0da84a9131aa362e4647b009678d0c58ea78.zip | |
xstop_analysis: change the order of addr/val in pnor data structure
GPEs require things to be on 8-byte boundary for uint64_t and 4-byte
for uint32_t. So, swapping the order helps align things.
Change-Id: I9de2660d46314583ab34cab9343239dbbfd21c8f
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43402
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Diffstat (limited to 'src/usr/diag')
| -rw-r--r-- | src/usr/diag/prdf/occ_firdata/pnorData_common.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/usr/diag/prdf/occ_firdata/pnorData_common.h b/src/usr/diag/prdf/occ_firdata/pnorData_common.h index 3d617a8f2..f565e48fa 100644 --- a/src/usr/diag/prdf/occ_firdata/pnorData_common.h +++ b/src/usr/diag/prdf/occ_firdata/pnorData_common.h @@ -142,10 +142,11 @@ static inline PNOR_Trgt_t PNOR_getTrgt( uint32_t i_trgtType, uint32_t i_chipPos, /** Information for a normal register. */ /* NOTE: This structure is 4-byte word aligned. */ +//The order matters here due to hardware limitations on the GPE typedef struct __attribute__((packed)) { - uint32_t addr; /** 32-bit address */ uint64_t val; /** 64-bit value */ + uint32_t addr; /** 32-bit address */ } PNOR_Reg_t; |
