diff options
| author | Zane Shelley <zshelle@us.ibm.com> | 2014-07-21 11:13:57 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-09-22 13:25:53 -0500 |
| commit | febedf95b66560310d0580598cd9cc2934578c9f (patch) | |
| tree | aa6476c72da233e25f01793cfb0670c5d14086e8 /src/usr/diag/prdf/test | |
| parent | 551a5fed6e653f3b81fe22641494521207350bdd (diff) | |
| download | talos-hostboot-febedf95b66560310d0580598cd9cc2934578c9f.tar.gz talos-hostboot-febedf95b66560310d0580598cd9cc2934578c9f.zip | |
PRD: fix ErrDataService::sdc ambiguity
The ErrDataService class had instance variable 'sdc', which was never
really needed as an instance variable. Issues arised where some code
used input variables and some used the instance variables. In some
cases, both were named the same which really confused things. I removed
the instance variable and forced it to be passed to functions if needed.
Change-Id: If34233214230992c8b77c1796dafedf61ee7a4f8
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/12402
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/13458
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/usr/diag/prdf/test')
| -rwxr-xr-x | src/usr/diag/prdf/test/prdfsimRasServices.C | 6 | ||||
| -rwxr-xr-x | src/usr/diag/prdf/test/prdfsimRasServices.H | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/usr/diag/prdf/test/prdfsimRasServices.C b/src/usr/diag/prdf/test/prdfsimRasServices.C index ef7fea494..4b7c0724c 100755 --- a/src/usr/diag/prdf/test/prdfsimRasServices.C +++ b/src/usr/diag/prdf/test/prdfsimRasServices.C @@ -34,7 +34,7 @@ namespace PRDF { errlHndl_t SimErrDataService::GenerateSrcPfa( ATTENTION_TYPE i_attnType, - ServiceDataCollector & i_sdc, + ServiceDataCollector & io_sdc, bool & o_initiateHwudump, TargetHandle_t & o_dumpTrgt, errlHndl_t & o_dumpErrl, @@ -47,11 +47,11 @@ errlHndl_t SimErrDataService::GenerateSrcPfa( ATTENTION_TYPE i_attnType, errlHndl_t errLog = NULL; // call the actual ras services function - errLog = ErrDataService::GenerateSrcPfa( i_attnType, i_sdc, + errLog = ErrDataService::GenerateSrcPfa( i_attnType, io_sdc, o_initiateHwudump, o_dumpTrgt, o_dumpErrl, o_dumpErrlActions ); - ErrorSignature * esig = i_sdc.GetErrorSignature(); + ErrorSignature * esig = io_sdc.GetErrorSignature(); // report the actual signature getSimServices().reportSig(esig->getChipId(), esig->getSigId()); diff --git a/src/usr/diag/prdf/test/prdfsimRasServices.H b/src/usr/diag/prdf/test/prdfsimRasServices.H index 1b36b2ea5..b53904f1d 100755 --- a/src/usr/diag/prdf/test/prdfsimRasServices.H +++ b/src/usr/diag/prdf/test/prdfsimRasServices.H @@ -47,7 +47,7 @@ class SimErrDataService : public ErrDataService /** * @brief Creates an SRC, PFA data, and error log from the SDC provided. * @param i_attnType Analysis attention type. - * @param i_sdc Target SDC. + * @param io_sdc Target SDC. * @param o_initiateHwudump whether or not to initiate hwudump * @param o_dumpTrgt The DUMP target * @param o_dumpErrl The DUMP error handle @@ -57,7 +57,7 @@ class SimErrDataService : public ErrDataService * @pre The Time of Error must be set in the given SDC. */ virtual errlHndl_t GenerateSrcPfa( ATTENTION_TYPE i_attnType, - ServiceDataCollector & i_sdc, + ServiceDataCollector & io_sdc, bool & o_initiateHwudump, TARGETING::TargetHandle_t & o_dumpTrgt, errlHndl_t & o_dumpErrl, |
