PRD: refactored SDC flag accessor functions

Change-Id: Ibe67862ff09a15e5b2caf3a195b8ceb13eaca12f
RTC: 135084
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/20461
Tested-by: Jenkins Server
Reviewed-by: BENJAMIN J. WEISENBECK <bweisenb@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Depends-on: I482d27e86f0af9a88f376ffdf873e8a0f624063a
Squashed: I556d942062252761df9413cfce056dd78c1ef536
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/21580
Tested-by: Jenkins OP Build CI
Tested-by: FSP CI Jenkins
Tested-by: Jenkins OP HW

8 files changed, 19 insertions, 19 deletions

diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMba.C b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMba.C
index 6dedb8895..be7686ed3 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMba.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMba.C
@@ -287,9 +287,9 @@ int32_t ClearServiceCallFlag( ExtensibleChip * i_chip,
 {
     if ( i_sc.service_data->IsAtThreshold() && !mfgMode() &&
          (CHECK_STOP != i_sc.service_data->getPrimaryAttnType()) &&
-         (!i_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS)) )
+         (!i_sc.service_data->queryFlag(ServiceDataCollector::UNIT_CS)) )
     {
-        i_sc.service_data->ClearFlag(ServiceDataCollector::SERVICE_CALL);
+        i_sc.service_data->clearFlag(ServiceDataCollector::SERVICE_CALL);
     }
 
     return SUCCESS;
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaTdCtlr_common.C b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaTdCtlr_common.C
index 700cd23e1..f4858e1df 100644
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaTdCtlr_common.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaTdCtlr_common.C
@@ -715,7 +715,7 @@ void CenMbaTdCtlrCommon::badPathErrorHandling( STEP_CODE_DATA_STRUCT & io_sc )
 
     // Just in case it was a legitimate maintenance command complete (error
     // log not committed) but something else failed.
-    io_sc.service_data->ClearFlag(ServiceDataCollector::DONT_COMMIT_ERRL);
+    io_sc.service_data->clearFlag(ServiceDataCollector::DONT_COMMIT_ERRL);
 
     #undef PRDF_FUNC
 }
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMemUtils.C b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMemUtils.C
index 7592067c9..798c741e0 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMemUtils.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMemUtils.C
@@ -349,7 +349,7 @@ int32_t checkMcsChannelFail( ExtensibleChip * i_mcsChip,
     do
     {
         // Skip if already handling unit checkstop.
-        if ( io_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS) )
+        if ( io_sc.service_data->IsUnitCS() )
             break;
 
         // Must be an MCS.
@@ -371,7 +371,7 @@ int32_t checkMcsChannelFail( ExtensibleChip * i_mcsChip,
         if ( !mcifir->IsBitSet(31) ) break; // No channel fail, so exit.
 
         // Set unit checkstop flag and cause attention type.
-        io_sc.service_data->SetFlag(ServiceDataCollector::UNIT_CS);
+        io_sc.service_data->setFlag(ServiceDataCollector::UNIT_CS);
         io_sc.service_data->setSecondaryAttnType(UNIT_CS);
         io_sc.service_data->SetThresholdMaskId(0);
 
@@ -425,7 +425,7 @@ int32_t chnlCsCleanup( ExtensibleChip *i_mbChip,
             break; // Cleanup has already been done.
 
         // Set it as SUE generation point.
-        i_sc.service_data->SetFlag( ServiceDataCollector::UERE );
+        i_sc.service_data->SetUERE();
 
         ExtensibleChip * mcsChip = mbdb->getMcsChip();
         if ( NULL == mcsChip )
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMembuf.C b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMembuf.C
index 49ba2e96e..1481a5dad 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMembuf.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMembuf.C
@@ -235,7 +235,7 @@ int32_t PreAnalysis( ExtensibleChip * i_mbChip, STEP_CODE_DATA_STRUCT & i_sc,
     do
     {
         // Skip if we're already analyzing a unit checkstop
-        if ( i_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS) )
+        if ( i_sc.service_data->IsUnitCS() )
             break;
 
         // Skip if we're analyzing a special attention.
@@ -261,7 +261,7 @@ int32_t PreAnalysis( ExtensibleChip * i_mbChip, STEP_CODE_DATA_STRUCT & i_sc,
         if ( fir->BitStringIsZero() ) break; // No unit checkstop
 
         // Set Unit checkstop flag
-        i_sc.service_data->SetFlag(ServiceDataCollector::UNIT_CS);
+        i_sc.service_data->setFlag(ServiceDataCollector::UNIT_CS);
         i_sc.service_data->SetThresholdMaskId(0);
 
         // Set the cause attention type
@@ -1260,9 +1260,9 @@ int32_t ClearServiceCallFlag( ExtensibleChip * i_chip,
 {
     if ( i_sc.service_data->IsAtThreshold() && !mfgMode() &&
          (CHECK_STOP != i_sc.service_data->getPrimaryAttnType()) &&
-         (!i_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS)) )
+         (!i_sc.service_data->queryFlag(ServiceDataCollector::UNIT_CS)) )
     {
-        i_sc.service_data->ClearFlag(ServiceDataCollector::SERVICE_CALL);
+        i_sc.service_data->clearFlag(ServiceDataCollector::SERVICE_CALL);
     }
 
     return SUCCESS;
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfP8Ex.C b/src/usr/diag/prdf/common/plat/pegasus/prdfP8Ex.C
index facab825e..4717285db 100644
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfP8Ex.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfP8Ex.C
@@ -59,9 +59,9 @@ int32_t ClearServiceCallFlag( ExtensibleChip * i_chip,
 {
     if ( i_sc.service_data->IsAtThreshold() && !mfgMode() &&
          (CHECK_STOP != i_sc.service_data->getPrimaryAttnType()) &&
-         (!i_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS)) )
+         (!i_sc.service_data->queryFlag(ServiceDataCollector::UNIT_CS)) )
     {
-        i_sc.service_data->ClearFlag(ServiceDataCollector::SERVICE_CALL);
+        i_sc.service_data->clearFlag(ServiceDataCollector::SERVICE_CALL);
     }
 
     return SUCCESS;
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfP8Mcs.C b/src/usr/diag/prdf/common/plat/pegasus/prdfP8Mcs.C
index 2fc36638c..ea36cb66b 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfP8Mcs.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfP8Mcs.C
@@ -228,9 +228,9 @@ int32_t ClearServiceCallFlag( ExtensibleChip * i_chip,
 {
     if ( i_sc.service_data->IsAtThreshold() && !mfgMode() &&
          (CHECK_STOP != i_sc.service_data->getPrimaryAttnType()) &&
-         (!i_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS)) )
+         (!i_sc.service_data->queryFlag(ServiceDataCollector::UNIT_CS)) )
     {
-        i_sc.service_data->ClearFlag(ServiceDataCollector::SERVICE_CALL);
+        i_sc.service_data->clearFlag(ServiceDataCollector::SERVICE_CALL);
     }
 
     return SUCCESS;
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfP8Proc.C b/src/usr/diag/prdf/common/plat/pegasus/prdfP8Proc.C
index 389e9f444..e7ffddbde 100755
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfP8Proc.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfP8Proc.C
@@ -826,9 +826,9 @@ int32_t ClearServiceCallFlag( ExtensibleChip * i_chip,
 {
     if ( i_sc.service_data->IsAtThreshold() && !mfgMode() &&
          (CHECK_STOP != i_sc.service_data->getPrimaryAttnType()) &&
-         (!i_sc.service_data->GetFlag(ServiceDataCollector::UNIT_CS)) )
+         (!i_sc.service_data->queryFlag(ServiceDataCollector::UNIT_CS)) )
     {
-        i_sc.service_data->ClearFlag(ServiceDataCollector::SERVICE_CALL);
+        i_sc.service_data->clearFlag(ServiceDataCollector::SERVICE_CALL);
     }
 
     return SUCCESS;
@@ -848,7 +848,7 @@ int32_t ClearServiceCallFlag_mnfgInfo( ExtensibleChip * i_chip,
 {
     if ( i_sc.service_data->IsAtThreshold() )
     {
-        i_sc.service_data->ClearFlag(ServiceDataCollector::SERVICE_CALL);
+        i_sc.service_data->clearFlag(ServiceDataCollector::SERVICE_CALL);
     }
 
     return SUCCESS;
diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfPlatUtil.C b/src/usr/diag/prdf/common/plat/pegasus/prdfPlatUtil.C
index 0e0cfc18d..1cb9f84e0 100644
--- a/src/usr/diag/prdf/common/plat/pegasus/prdfPlatUtil.C
+++ b/src/usr/diag/prdf/common/plat/pegasus/prdfPlatUtil.C
@@ -59,12 +59,12 @@ bool ignoreErrorForSapphire( STEP_CODE_DATA_STRUCT & i_stepcode )
             if( !isSpConfigFsp() )
             {
                 //Mask the error on first instance for FSP less systems.
-                i_stepcode.service_data->SetFlag(
+                i_stepcode.service_data->setFlag(
                                 ServiceDataCollector::AT_THRESHOLD );
             }
 
             //Prevent predictive callout of the chip.
-            i_stepcode.service_data->ClearFlag(
+            i_stepcode.service_data->clearFlag(
                                 ServiceDataCollector::SERVICE_CALL );
 
             ignoreError = true;