diff options
| author | Zane Shelley <zshelle@us.ibm.com> | 2018-04-26 16:36:40 -0500 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2018-05-04 22:26:22 -0400 |
| commit | 453283ebfde2d76bd999af0edc1c5b16cf836773 (patch) | |
| tree | 6256e491a63434dd9dfc06db70897ad8e68148c9 /src/usr/diag/prdf/common/plat/prdfPlatServices_common.C | |
| parent | 7f4b95b28d2119d431c2c5a9d0ec1b93f7d5d59f (diff) | |
| download | talos-hostboot-453283ebfde2d76bd999af0edc1c5b16cf836773.tar.gz talos-hostboot-453283ebfde2d76bd999af0edc1c5b16cf836773.zip | |
PRD: Fixed logic errors in isMembufOnDimm() that broke Nimbus
Change-Id: Ie7d8893ef3a552206bddfd4f49dcea161d0912d1
RTC: 192287
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57916
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58325
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/usr/diag/prdf/common/plat/prdfPlatServices_common.C')
| -rw-r--r-- | src/usr/diag/prdf/common/plat/prdfPlatServices_common.C | 21 |
1 files changed, 3 insertions, 18 deletions
diff --git a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C index d66303abe..e4df155cc 100644 --- a/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C +++ b/src/usr/diag/prdf/common/plat/prdfPlatServices_common.C @@ -677,16 +677,7 @@ int32_t getMemBufRawCardType( TargetHandle_t i_mba, o_rc = FAIL; break; } - bool isCenDimm = false; - o_rc = isMembufOnDimm( i_mba, isCenDimm ); - if ( SUCCESS != o_rc ) - { - PRDF_ERR( PRDF_FUNC "isMembufOnDimm() failed on MBA 0x%08x", - getHuid(i_mba) ); - break; - } - - if ( !isCenDimm ) + if ( !isMembufOnDimm<TYPE_MBA>(i_mba) ) { PRDF_ERR( PRDF_FUNC "MBA 0x%08x is not on a buffered DIMM", getHuid(i_mba) ); @@ -721,14 +712,8 @@ int32_t getMemBufRawCardType( TargetHandle_t i_mba, o_rc = FAIL; break; } - uint8_t l_version = 0; - o_rc = getDramGen(i_mba, l_version); - if ( SUCCESS != o_rc ) - { - PRDF_ERR(PRDF_FUNC "Fail DramVers x%08X"" HUID:x%08X", - l_version, getHuid(i_mba) ); - break; - } + uint8_t l_version = getDramGen<TYPE_MBA>( i_mba ); + // Centaur raw card types are only used for DRAM site locations. If an // invalid wiring type is passed to the error log parser, the parser // will simply print out the symbol and other data instead of |
