PRD: Refactor prdfPlatServices

The prdfPlatServices_common.[HC] files should only contain code that is
common between FSP and Hostboot.

The prdfTargetServices.[HC] files should only contain code specific to
the common FSP/Hostboot targeting code.

The FSP prdfPlatServices.[HC] and Hostboot prdfPlatServices.[HC] files
will contain code that is specific to FSP or Hostboot, respectively.

Only prdfPlatServices_common.H will include prdfTargetServices.H.

Only the prdfPlatServices.H files will include prdfPlatServices_common.H.

All user code should include the respective prdfPlatServices.H file.

Change-Id: I6e723d6e6602194abfc24ee9c20c1949c393c0e2
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3041
Tested-by: Jenkins Server
Reviewed-by: Christopher T. Phan <cphan@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/3213

1 files changed, 18 insertions, 19 deletions

diff --git a/src/usr/diag/prdf/common/iipglobl.h b/src/usr/diag/prdf/common/iipglobl.h
index 3514a9601..d21d49a5a 100755
--- a/src/usr/diag/prdf/common/iipglobl.h
+++ b/src/usr/diag/prdf/common/iipglobl.h
@@ -368,9 +368,10 @@ class System;
 
 #endif
 
-// ----------- Hostboot macros begin -----------
 #ifdef  __HOSTBOOT_MODULE
 
+// ----------- Hostboot macros begin -------------------------------------------
+
 /**
  * @brief function to create an error log.
  */
@@ -442,19 +443,22 @@ class System;
  * @brief Interface to request a Hardware Unit dump collection
  */
 // FIXME - need to implement in Hostboot
-#define PRDF_HWUDUMP(io_dumpErrl, i_errl,   \
-                     i_content, i_dumpHuid)
+#define PRDF_HWUDUMP( i_errl, i_content, i_huid ) \
+  SUCCESS
 
 /**
  * @brief Interface to deconfig target at Runtime (Not valid in Hostboot)
  */
-#define PRDF_RUNTIME_DECONFIG(io_errl, i_pTarget)
+// FIXME - need to implement in Hostboot
+#define PRDF_RUNTIME_DECONFIG( i_pTarget ) \
+  SUCCESS
 
-// ----------- Hostboot macros end   -----------
+// ----------- Hostboot macros end   -------------------------------------------
 
-// ----------- FSP macros begin -----------
 #else
 
+// ----------- FSP macros begin ------------------------------------------------
+
 /**
  * @brief function to create an error log.
  */
@@ -541,22 +545,17 @@ class System;
 /**
  * @brief Interface to request a Hardware Unit dump collection
  */
-#define PRDF_HWUDUMP(io_dumpErrl, i_errl,   \
-                     i_content, i_dumpHuid) \
-  SrciSrc l_src(*(i_errl->getSRC(0)));          \
-  io_dumpErrl= PlatServices::dumpHWURequest( i_content, \
-                                             PRDF_COMP_ID,  \
-                                             i_errl->plid(),\
-                                             l_src,         \
-                                             i_dumpHuid );
+#define PRDF_HWUDUMP( i_errl, i_content, i_huid ) \
+  PlatServices::dumpHWURequest( i_errl, i_content, i_huid )
 
 /**
  * @brief Interface to deconfig target at Runtime
  */
-#define PRDF_RUNTIME_DECONFIG( io_errl, i_target ) \
-    io_errl = PlatServices::runtimeDeconfig( i_target );
+#define PRDF_RUNTIME_DECONFIG( i_target ) \
+    PlatServices::runtimeDeconfig( i_target )
 
-// ----------- FSP macros end   -----------
-#endif
+// ----------- FSP macros end   ------------------------------------------------
 
-#endif
+#endif // not __HOSTBOOT_MODULE
+
+#endif // IIPGLOBL_H