summaryrefslogtreecommitdiffstats
path: root/src/usr/diag/prdf/common/framework
diff options
context:
space:
mode:
authorPrem Shanker Jha <premjha2@in.ibm.com>2013-04-16 01:45:31 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2013-04-16 14:16:15 -0500
commitc524a88d95da18e63179e5c251bcbfd0a89d60b3 (patch)
tree59a06b22fff92c26b76a39cb2984c03856f5cd17 /src/usr/diag/prdf/common/framework
parent503edd30dc71898ac7156e3adcf135c308fb00b9 (diff)
downloadtalos-hostboot-c524a88d95da18e63179e5c251bcbfd0a89d60b3.tar.gz
talos-hostboot-c524a88d95da18e63179e5c251bcbfd0a89d60b3.zip
PRDF:Removed Read from AccessBitString
Addessed defect SW198089 Change-Id: Id5f4d2db425a72d689af92541620506e806deb56 Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4068 Tested-by: Jenkins Server Reviewed-by: Christopher T. Phan <cphan@us.ibm.com> Reviewed-by: Zane Shelley <zshelle@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com> Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4077
Diffstat (limited to 'src/usr/diag/prdf/common/framework')
-rwxr-xr-xsrc/usr/diag/prdf/common/framework/register/prdfScomRegister.C9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C b/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C
index 803fb5c8f..06d4c51a3 100755
--- a/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C
+++ b/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C
@@ -113,12 +113,9 @@ const BIT_STRING_CLASS *ScomRegister::GetBitString( ATTENTION_TYPE i_type )const
BIT_STRING_CLASS & ScomRegister::AccessBitString( )
{
bool l_readStat = false;
- //Expectation is, caller shall first call Read( ) and then AccessBitString.
- //This leaves an opportunity of mistake. One may call AccessBitString
- //without calling Read() first. As a result, a stray entry in cache gets
- //created which shall never be in sync with hardware. Calling Read( ) before
- //readCache( ) inside function eliminates this scenario.
- Read( );
+ //FIXME RTC 51455 We need to find a way to make AccessBitString independent
+ //of Read. Calling Read inside this function shall make it read even
+ //write only registers. This operation shall fail on actual hardware.
return ( readCache( l_readStat ) );
}
OpenPOWER on IntegriCloud