diff options
| author | Zane Shelley <zshelle@us.ibm.com> | 2017-01-31 14:03:18 -0600 |
|---|---|---|
| committer | Zane C. Shelley <zshelle@us.ibm.com> | 2017-02-10 17:34:57 -0500 |
| commit | 982dd4c4466b2589654c90823fd956ecfa8199f3 (patch) | |
| tree | 039cc2fbbb7ceed492437a01aab2becdb9db5be4 /src/usr/diag/prdf/common/framework | |
| parent | a56b9bde18a2baac1b4e9b8f31ba1d7ff8f4ca71 (diff) | |
| download | talos-hostboot-982dd4c4466b2589654c90823fd956ecfa8199f3.tar.gz talos-hostboot-982dd4c4466b2589654c90823fd956ecfa8199f3.zip | |
PRD: cleaned BitString::SetBits()
This function had a off-by-one error that could access memory beyond
the available memory space.
Change-Id: Ie9142530b7b9926c2eb9499d2cc11f7fd8bf6cca
RTC: 167819
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35689
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36202
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/usr/diag/prdf/common/framework')
3 files changed, 5 insertions, 5 deletions
diff --git a/src/usr/diag/prdf/common/framework/register/iipErrorRegisterMask.h b/src/usr/diag/prdf/common/framework/register/iipErrorRegisterMask.h index bf435153f..99b6fc509 100755 --- a/src/usr/diag/prdf/common/framework/register/iipErrorRegisterMask.h +++ b/src/usr/diag/prdf/common/framework/register/iipErrorRegisterMask.h @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2015 */ +/* Contributors Listed Below - COPYRIGHT 2012,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -218,7 +218,7 @@ inline void ErrorRegisterMask::SetMaskBit(uint32_t bitPosition) { bitStringMask.Set(bitPosition); } inline void ErrorRegisterMask::SetMaskBits(const BIT_STRING_CLASS & bitString) -{ bitStringMask.SetBits(bitString); } +{ bitStringMask.setString(bitString); } } // end namespace PRDF diff --git a/src/usr/diag/prdf/common/framework/register/prdfCaptureData.C b/src/usr/diag/prdf/common/framework/register/prdfCaptureData.C index 907b1c28f..63fd52692 100755 --- a/src/usr/diag/prdf/common/framework/register/prdfCaptureData.C +++ b/src/usr/diag/prdf/common/framework/register/prdfCaptureData.C @@ -103,7 +103,7 @@ void CaptureData::AddDataElement( TargetHandle_t i_trgt, int i_scomId, // Use a BitString to copy i_bs to the buffer. BIT_STRING_ADDRESS_CLASS bs ( 0, i_bs->getBitLen(), (CPU_WORD *)buf ); - bs.SetBits( *i_bs ); + bs.setString( *i_bs ); // Create the new data element. Data element( i_trgt, i_scomId, sz_buf, buf ); diff --git a/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C b/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C index ae1f7d386..e06c4e615 100755 --- a/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C +++ b/src/usr/diag/prdf/common/framework/register/prdfScomRegister.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2015 */ +/* Contributors Listed Below - COPYRIGHT 2012,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -78,7 +78,7 @@ namespace PRDF void ScomRegister::SetBitString( const BIT_STRING_CLASS *bs ) { BIT_STRING_CLASS & l_string = AccessBitString(); - l_string.SetBits(*bs); + l_string.setString(*bs); } |
