diff options
author | Chris Phan <cphan@us.ibm.com> | 2014-12-08 13:27:22 -0600 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2015-02-04 12:06:29 -0600 |
commit | ed9910fb0c31c40656651bfc20ee071192be83e4 (patch) | |
tree | f9f5c2bde1eed8668bc04d0012e0e20172fb3e68 /src/usr/diag/prdf/common/framework/config | |
parent | 0319f088919e7a9ab8d5804405cad33beda4e035 (diff) | |
download | talos-hostboot-ed9910fb0c31c40656651bfc20ee071192be83e4.tar.gz talos-hostboot-ed9910fb0c31c40656651bfc20ee071192be83e4.zip |
PRD: clean up fixme/todo in prd code
Change-Id: I2ec9df44ab66b7eed959ce53964e2bfa611516d7
RTC: 116444
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/14817
Tested-by: Jenkins Server
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Reviewed-by: Prem Shanker Jha <premjha2@in.ibm.com>
Reviewed-by: Bilicon Patil <bilpatil@in.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/15527
Diffstat (limited to 'src/usr/diag/prdf/common/framework/config')
3 files changed, 8 insertions, 10 deletions
diff --git a/src/usr/diag/prdf/common/framework/config/iipDomainContainer.C b/src/usr/diag/prdf/common/framework/config/iipDomainContainer.C index 3fe03b258..1d56e0ed2 100755 --- a/src/usr/diag/prdf/common/framework/config/iipDomainContainer.C +++ b/src/usr/diag/prdf/common/framework/config/iipDomainContainer.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2014 */ +/* Contributors Listed Below - COPYRIGHT 2012,2015 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -70,11 +70,8 @@ namespace PRDF // Member Function Specifications //--------------------------------------------------------------------- -// @jl02 a Start // This is used with the CHIP_CLASS vectors to remove one that matches a chipID // Predicate function for comparing chip IDs. This is required by remove_if from STL. -// TODO:FIXME: Add compiler directives or some method to make sure the type handling here -// is generic enough or correct enough to handle future use of this functionality. class prdfCompareChipIds: public std::unary_function<void*&, bool> { public: @@ -100,7 +97,6 @@ class prdfCompareChipIds: public std::unary_function<void*&, bool> //Private storage for value passed in. TARGETING::TargetHandle_t __cid; }; -// @jl02 a Stop template<class T> inline diff --git a/src/usr/diag/prdf/common/framework/config/prdfFabricDomain.C b/src/usr/diag/prdf/common/framework/config/prdfFabricDomain.C index d499c3ae9..f91ce88bf 100755 --- a/src/usr/diag/prdf/common/framework/config/prdfFabricDomain.C +++ b/src/usr/diag/prdf/common/framework/config/prdfFabricDomain.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2014 */ +/* Contributors Listed Below - COPYRIGHT 2012,2015 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -242,8 +242,9 @@ void FabricDomain::SortForXstop() } else if (0 == l_internalOnlyCount) { - // TODO : add trace here... continue with analysis to determine - // which chip origined though. + PRDF_TRAC("[FabricDomain::SortForXstop] continue " + "with analysis to determine which chip " + "sourced the error."); } // --- Do graph reduction --- diff --git a/src/usr/diag/prdf/common/framework/config/prdfParentDomain.C b/src/usr/diag/prdf/common/framework/config/prdfParentDomain.C index 8ad6a5990..38c83670e 100755 --- a/src/usr/diag/prdf/common/framework/config/prdfParentDomain.C +++ b/src/usr/diag/prdf/common/framework/config/prdfParentDomain.C @@ -5,7 +5,9 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* COPYRIGHT International Business Machines Corp. 1996,2014 */ +/* Contributors Listed Below - COPYRIGHT 2012,2015 */ +/* [+] International Business Machines Corp. */ +/* */ /* */ /* Licensed under the Apache License, Version 2.0 (the "License"); */ /* you may not use this file except in compliance with the License. */ @@ -71,7 +73,6 @@ namespace PRDF template<class T> ParentDomain<T>::ParentDomain() { - //TODO::Do I need to have this here to clear out the vector? VectorOfDomainPointerType iv_childrenDomains(); } |