diff options
| author | Stephen Cprek <smcprek@us.ibm.com> | 2017-02-01 16:41:49 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-02-03 10:41:20 -0500 |
| commit | b90b803882cce38c761fe3a85d7fbcaff09b30a8 (patch) | |
| tree | b7edc92b63869a4ec0b3cca3da9d77ea672f3943 /src/securerom/ROM.C | |
| parent | 0acb956bb98770c4ffcc65759c32b6032bfeb921 (diff) | |
| download | talos-hostboot-b90b803882cce38c761fe3a85d7fbcaff09b30a8.tar.gz talos-hostboot-b90b803882cce38c761fe3a85d7fbcaff09b30a8.zip | |
Replace hardcodes with const variables in ROM.C
Change-Id: I1243dc86814284bdd3c6ca9a92b5731afa5929ae
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35760
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/securerom/ROM.C')
| -rw-r--r-- | src/securerom/ROM.C | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/securerom/ROM.C b/src/securerom/ROM.C index bb1438772..97fe1f479 100644 --- a/src/securerom/ROM.C +++ b/src/securerom/ROM.C @@ -139,7 +139,7 @@ ROM_response ROM_verify( ROM_container_raw* container, // process hw keys // test for valid hw keys - SHA512_Hash(container->hw_pkey_a, 3*sizeof(ecc_key_t), &digest); + SHA512_Hash(container->hw_pkey_a, HW_KEY_COUNT*sizeof(ecc_key_t), &digest); if(memcmp(params->hw_key_hash, digest, sizeof(sha2_hash_t))) { FAILED(HW_KEY_HASH_TEST,"invalid hw keys"); @@ -156,7 +156,8 @@ ROM_response ROM_verify( ROM_container_raw* container, hw_data = (ROM_prefix_data_raw*) (prefix->ecid + prefix->ecid_count*ECID_SIZE); SHA512_Hash((uint8_t*)prefix, PREFIX_HEADER_SIZE(prefix), &digest); - if(!multi_key_verify(digest, 3, container->hw_pkey_a, hw_data->hw_sig_a)) + if(!multi_key_verify(digest, HW_KEY_COUNT, container->hw_pkey_a, + hw_data->hw_sig_a)) { FAILED(HW_SIGNATURE_TEST,"invalid hw signature"); } @@ -173,7 +174,8 @@ ROM_response ROM_verify( ROM_container_raw* container, FAILED(PREFIX_HASH_TEST,"invalid prefix payload hash"); } // test for valid sw key count - if (prefix->sw_key_count < 1 || prefix->sw_key_count > 3) + if (prefix->sw_key_count < SW_KEY_COUNT_MIN || + prefix->sw_key_count > SW_KEY_COUNT_MAX) { FAILED(SW_KEY_INVALID_COUNT,"sw key count not between 1-3"); } |
