diff options
author | Christian Geddes <crgeddes@us.ibm.com> | 2019-11-06 16:38:29 -0600 |
---|---|---|
committer | Daniel M Crowell <dcrowell@us.ibm.com> | 2019-11-07 23:17:54 -0600 |
commit | c016e9860f3dcd56e1332ca455bad8471952c92b (patch) | |
tree | 256b497d26b8b93ee85aa2ed7559197ac67113e4 /src/libc++ | |
parent | 9c7a264f84fcab5577ee6a2b48f6a2d01c12da35 (diff) | |
download | talos-hostboot-c016e9860f3dcd56e1332ca455bad8471952c92b.tar.gz talos-hostboot-c016e9860f3dcd56e1332ca455bad8471952c92b.zip |
Avoid commiting errors inside fapi2_i2c device driver
There are instances where we expect NACK errors returned from i2c
requests, for example when waiting for the ocmbs to declare themselves
"ready". In these cases we do not want to flood the error log
with expected I2C nack errors. To avoid this, instead of committing
retriable errors inside of the fapi2_i2c device driver when the MAX
RETRY ATTEMPTS is reached we will instead just add traces to the err
that gets returned to the caller that explain previous retryable errs
occured. In the case where we hit retryable errors and eventually hit
and non-retryable error the retryable error is committed in the driver
and the non-retryable error is returned to the caller. Also this commit
adds some timings to the error log so we can tell how long our attempts
took.
Change-Id: I9a5ee0bfe088444aa7fecd974f61514c40b320a6
CQ: SW480155
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86419
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/libc++')
0 files changed, 0 insertions, 0 deletions