diff options
| author | Luis Fernandez <luis.fernandez@ibm.com> | 2019-02-21 14:13:44 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-04-05 16:52:10 -0500 |
| commit | 4995ec0ba6f15e03deb4b9ad1dc215f3f8993acb (patch) | |
| tree | 35524433b3a4b268b12516cfdf2dd033688599b2 /src/lib/utilmisc.C | |
| parent | c8651104f00db7538147ab4cea9c9a3a8df5e500 (diff) | |
| download | talos-hostboot-4995ec0ba6f15e03deb4b9ad1dc215f3f8993acb.tar.gz talos-hostboot-4995ec0ba6f15e03deb4b9ad1dc215f3f8993acb.zip | |
HB Improvements: Fix compiler warnings on modern compilers
Resolve warnings when compiling with gcc 4.8. Compiled with GCC 7.3,
no more compile errors/warnings; build ends with caught exception from
linker. This commit compiles with GCC 8.2, no more error/warnings; except
for a linking warning.
Change-Id: Ib5d7c2b5bd350edc76ee2c7de96896154cd44420
RTC: 202716
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72271
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/lib/utilmisc.C')
| -rw-r--r-- | src/lib/utilmisc.C | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/lib/utilmisc.C b/src/lib/utilmisc.C index 36f568d11..a3771a303 100644 --- a/src/lib/utilmisc.C +++ b/src/lib/utilmisc.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2014,2018 */ +/* Contributors Listed Below - COPYRIGHT 2014,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -29,14 +29,19 @@ namespace Util { bool isSimics() __attribute__((alias("__isSimicsRunning"))); -extern "C" void __isSimicsRunning() NEVER_INLINE; +extern "C" bool __isSimicsRunning() NEVER_INLINE; -void __isSimicsRunning() +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wreturn-type" + +bool __isSimicsRunning() { asm volatile("li 3, 0"); MAGIC_INSTRUCTION(MAGIC_SIMICS_CHECK); } +#pragma GCC diagnostic pop + bool isSimicsRunning() { static bool simics = isSimics(); |
