summaryrefslogtreecommitdiffstats
path: root/src/include
diff options
context:
space:
mode:
authorMatt Derksen <mderkse1@us.ibm.com>2018-02-21 09:12:47 -0600
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-02-27 14:15:54 -0500
commitd6d402588868abe6a71b6078a52c99f83f6f7ffb (patch)
tree4c26eb5c9e26c8635a8d540a4cbd57998a2b0009 /src/include
parent8f1ef46890d9d53df652cfa823f310adae39d47f (diff)
downloadtalos-hostboot-d6d402588868abe6a71b6078a52c99f83f6f7ffb.tar.gz
talos-hostboot-d6d402588868abe6a71b6078a52c99f83f6f7ffb.zip
Cleanup hbrt msg code to be easier to understand and update
Cleanup based on review comments on hbrt attribute update msg code. Change-Id: I10c957f1bf7b6cab77315af6c65f5e0f62b5c893 RTC:186991 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54494 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian E. Bakke <bbakke@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include')
-rw-r--r--src/include/runtime/generic_hbrt_fsp_message.H9
1 files changed, 9 insertions, 0 deletions
diff --git a/src/include/runtime/generic_hbrt_fsp_message.H b/src/include/runtime/generic_hbrt_fsp_message.H
index 9a3ecfdb4..01c972880 100644
--- a/src/include/runtime/generic_hbrt_fsp_message.H
+++ b/src/include/runtime/generic_hbrt_fsp_message.H
@@ -84,10 +84,18 @@ struct SbeRetryReqData_t
*/
struct HbrtAttrSyncData_t
{
+ // HUID of target on which we want to update the attribute
uint32_t huid;
+
+ // Attribute ID of attribute to update
TARGETING::ATTRIBUTE_ID attrID;
+
+ // size of attribute data in bytes
uint32_t sizeOfAttrData;
+
+ // first byte of <sizeOfAttrData> bytes of attribute data
uint8_t attrDataStart;
+
} PACKED ;
/**
@@ -172,6 +180,7 @@ struct GenericFspMboxMessage_t
// to do casting to other types:
// MyDataType_t* mydatatype =
// (MyDataType_t*)&(l_generic_msg.data);
+ // more than 8 bytes of data is possible
// A method to set the local vars to a default state
void initialize()
OpenPOWER on IntegriCloud