summaryrefslogtreecommitdiffstats
path: root/src/include
diff options
context:
space:
mode:
authorChristian Geddes <crgeddes@us.ibm.com>2018-09-19 17:39:16 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-09-27 13:48:18 -0500
commit7511e132b1e50c88a679f05528b7e6118b7e8836 (patch)
tree163cc419850a87c0f57f6bf65c5f90a1f02745f3 /src/include
parent0d43552dfb6dcac11a447cfcb2ba86bfdf552c29 (diff)
downloadtalos-hostboot-7511e132b1e50c88a679f05528b7e6118b7e8836.tar.gz
talos-hostboot-7511e132b1e50c88a679f05528b7e6118b7e8836.zip
Correctly handle psu FFDC on OpenPower Systems
Prior to this change, there was a switch statement that was saying "if this RC is found in the psu FFDC, then do this recovery action" that is obviously not very easy to maintain because for every error we need to add the proper action. Instead of this, now we will just look if any GARD records were created as part of the error found in the FFDC. If a gard was found , Hostboot will stop trying to recover the SBE and instead enter a reconfig loop to try and IPL w/ the target garded out. Again this only applies to OP system, in the FSP world we will commit the error logs w/ the gard records and then TI telling HWSV they need to look at the SBE Change-Id: I04e03feebf2bbd1eae2d725bee31993062fe7c94 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66374 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include')
-rw-r--r--src/include/usr/sbeio/sbe_retry_handler.H24
1 files changed, 0 insertions, 24 deletions
diff --git a/src/include/usr/sbeio/sbe_retry_handler.H b/src/include/usr/sbeio/sbe_retry_handler.H
index 747f2fb90..85ce22cfa 100644
--- a/src/include/usr/sbeio/sbe_retry_handler.H
+++ b/src/include/usr/sbeio/sbe_retry_handler.H
@@ -270,17 +270,6 @@ class SbeRetryHandler
*/
errlHndl_t switch_sbe_sides(TARGETING::Target * i_target);
-
- /**
- * @brief This is the switch case that identifies the action needed
- * for the RC value in an SBE FFDC package.
- *
- * @param[in] i_rc - RC value from SBE FFDC package
- *
- * @return - pass(0) or specific returned SBE action
- */
- uint32_t action_for_ffdc_rc( uint32_t i_rc);
-
/**
* @brief This function handles the call to the p9_get_sbe_msg_handler.
* It will read the sbe msg register (Cfam 2809 or Scom 50009)
@@ -364,19 +353,6 @@ class SbeRetryHandler
uint8_t iv_currentSideBootAttempts;
/*
- * @brief If the asyncFFDC bit is found to be set on the status register
- * this indicates to hostboot that the SBE was able to collect
- * FFDC about what went wrong in its attempt to boot itself
- * in this case Hostboot will send a FIFO chip op to the SBE
- * so the SBE will write the FFDC data out to memory where
- * Hostboot can parse it. Note that after the SBE writes
- * the data to memory the asyncFFDC bit on the status register
- * will be off.
- */
- bool iv_ffdcSetAction;
-
-
- /*
* @brief The mode of operation that needs to be run through the
* SbeRetryHandler. The different modes are specified in the
* SBE_MODE_OF_OPERATION enum
OpenPOWER on IntegriCloud