diff options
| author | Matthew Raybuck <matthew.raybuck@ibm.com> | 2019-09-13 10:24:48 -0500 |
|---|---|---|
| committer | Daniel M Crowell <dcrowell@us.ibm.com> | 2019-09-14 14:58:35 -0500 |
| commit | 60fbee21b04909a953e4a8a742d6e74f52c43724 (patch) | |
| tree | 69f1a9f367ae6fe882ce35510c08c3a44de62a76 /src/include | |
| parent | 7a27f4603a1b222e2d527d1167e5a3c3653c404b (diff) | |
| download | talos-hostboot-60fbee21b04909a953e4a8a742d6e74f52c43724.tar.gz talos-hostboot-60fbee21b04909a953e4a8a742d6e74f52c43724.zip | |
Fix bad arguments to additional FFDC capture in BPM Update code
In bpm_update.C there were two places where the wrong errl was being
given as a parameter to FFDC functions. The errl supplied was nullptr
causing hostboot to crash as a result. This commit fixes that by
suppling the correct errl.
Change-Id: I50e8459d2b3602177ca740059a706613402c3e95
RTC:212448
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83781
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/usr/isteps/nvdimm/nvdimm.H | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/include/usr/isteps/nvdimm/nvdimm.H b/src/include/usr/isteps/nvdimm/nvdimm.H index 9ccfa0e7f..2aae34c82 100644 --- a/src/include/usr/isteps/nvdimm/nvdimm.H +++ b/src/include/usr/isteps/nvdimm/nvdimm.H @@ -406,7 +406,7 @@ errlHndl_t compareCksum(TARGETING::Target* i_nvdimm, * * @param[in] i_nvdimm - nvdimm target * - * @param[inout] io_err - error log to add FFDC data + * @param[inout] io_err - error log to add FFDC data. Must not be nullptr * */ void nvdimmAddVendorLog(TARGETING::Target *i_nvdimm, errlHndl_t& io_err); @@ -419,7 +419,7 @@ void nvdimmAddVendorLog(TARGETING::Target *i_nvdimm, errlHndl_t& io_err); * * @param[in] i_nvdimm - nvdimm target * - * @param[in] io_err - error log to add FFDC data + * @param[in] io_err - error log to add FFDC data. Must not be nullptr * */ void nvdimmAddUpdateRegs(TARGETING::Target *i_nvdimm, errlHndl_t& io_err); @@ -440,7 +440,7 @@ void nvdimmAddUpdateRegs(TARGETING::Target *i_nvdimm, errlHndl_t& io_err); * * @param[in] i_nvdimm - nvdimm target * - * @param[inout] io_err - error log to add FFDC data + * @param[inout] io_err - error log to add FFDC data. Must not be nullptr * */ void nvdimmAddPage4Regs(TARGETING::Target *i_nvdimm, errlHndl_t& io_err); |
