summaryrefslogtreecommitdiffstats
path: root/src/include
diff options
context:
space:
mode:
authorChristian Geddes <crgeddes@us.ibm.com>2018-01-29 15:02:12 -0600
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-02-04 14:29:34 -0500
commit32a051104ae970748d8512278ab169320a6393d2 (patch)
tree763493fa1166576bdccf79ac2cd2339c6fa7a990 /src/include
parent70ec114fdfd417b99808633958c9600f36aca609 (diff)
downloadtalos-hostboot-32a051104ae970748d8512278ab169320a6393d2.tar.gz
talos-hostboot-32a051104ae970748d8512278ab169320a6393d2.zip
Always have secureModeDisable bit set to 0 in sbe_retry_handler
After talking with the HWP writers for the sbe_extract_rc HWP they told us we should always act like the secureModeDisable bit is false. The only reason that option is there is for lab use and we shouldnt ever use it. This commit makes that bit always 0 Change-Id: Id781df3a95ffdf5ec82624aebe6830f17d7dcf2b Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52861 Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include')
-rw-r--r--src/include/usr/sbeio/sbe_retry_handler.H4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/include/usr/sbeio/sbe_retry_handler.H b/src/include/usr/sbeio/sbe_retry_handler.H
index 2042e4d41..47e68e7da 100644
--- a/src/include/usr/sbeio/sbe_retry_handler.H
+++ b/src/include/usr/sbeio/sbe_retry_handler.H
@@ -285,6 +285,10 @@ class SbeRetryHandler
/*
* @brief Bit used for testing in the lab with systems that have secure
* mode disabled.
+ * NOTE: This bit is only used in the lab when running this HWP with cronus.
+ * We offered to have this bit set in FW based on the security settings of the
+ * system HW people told us it would be safer for us to always assume this bit
+ * is off in FW, so we will leave this bit as 0 until the HW devs tell us to use it.
*/
bool iv_secureModeDisabled;
OpenPOWER on IntegriCloud