diff options
| author | Mike Baiocchi <mbaiocch@us.ibm.com> | 2018-06-21 08:16:37 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-07-03 17:13:07 -0400 |
| commit | 1759af757bd8f9a13386c4fb4624bd93394af67b (patch) | |
| tree | 630cbf001cf10a15a9c2f939c3c2ec71f2f44808 /src/include | |
| parent | e5dfc3ab0ec51ee63205c7064b7b4a4c4b8ba46f (diff) | |
| download | talos-hostboot-1759af757bd8f9a13386c4fb4624bd93394af67b.tar.gz talos-hostboot-1759af757bd8f9a13386c4fb4624bd93394af67b.zip | |
Add error callouts and other improvements for Node Communications
This code adds bus, hw, code, etc callouts to the appropriate errors.
It also cleans up other TODOs, refactors some functions, and applies
somes fixes found in testing.
Change-Id: I462cdb2c4e313c277a3e0542f740e82ede3313f3
RTC:184518
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61813
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/usr/errl/errlentry.H | 16 | ||||
| -rw-r--r-- | src/include/usr/hwas/common/hwasCallout.H | 1 | ||||
| -rw-r--r-- | src/include/usr/secureboot/secure_reasoncodes.H | 4 |
3 files changed, 19 insertions, 2 deletions
diff --git a/src/include/usr/errl/errlentry.H b/src/include/usr/errl/errlentry.H index 4a3c8a634..3ed040ae0 100644 --- a/src/include/usr/errl/errlentry.H +++ b/src/include/usr/errl/errlentry.H @@ -557,6 +557,22 @@ public: const HWAS::callOutPriority i_priority); /** + * @brief Add a bus callout with entity paths + * + * @param[in] i_target1 The PHYS_PATH of HW bus endpoint target1 + * @param[in] i_target2 The PHYS_PATH of HW bus endpoint target2 + * @param[in] i_busType The hardware bus type + * @param[in] i_priority Priority of the callout + * + * @return void + */ + void addBusCallout(const TARGETING::EntityPath & i_target1, + const TARGETING::EntityPath & i_target2, + HWAS::busTypeEnum i_busType, + HWAS::callOutPriority i_priority); + + + /** * @brief Add a hardware callout * * @param[in] i_target The hardware target diff --git a/src/include/usr/hwas/common/hwasCallout.H b/src/include/usr/hwas/common/hwasCallout.H index c9e3d5266..9bb0722fa 100644 --- a/src/include/usr/hwas/common/hwasCallout.H +++ b/src/include/usr/hwas/common/hwasCallout.H @@ -159,6 +159,7 @@ enum partTypeEnum MEM_REF_CLOCK = 9, PROC_REF_CLOCK = 10, PCI_REF_CLOCK = 11, + // @TODO 195920 Remove SMP_CABLE once HWSV code no longer references it SMP_CABLE = 12, //Target is SMPGROUP }; diff --git a/src/include/usr/secureboot/secure_reasoncodes.H b/src/include/usr/secureboot/secure_reasoncodes.H index 30609603d..2f2ec75ef 100644 --- a/src/include/usr/secureboot/secure_reasoncodes.H +++ b/src/include/usr/secureboot/secure_reasoncodes.H @@ -62,7 +62,7 @@ namespace SECUREBOOT MOD_NCEX_MASTER = 0x27, MOD_NCEX_SLAVE = 0x28, MOD_NCEX_GET_RANDOM = 0x29, - MOD_NCEX_RECV = 0x2A, + MOD_NC_RECV = 0x2A, }; enum SECUREReasonCode @@ -102,7 +102,7 @@ namespace SECUREBOOT RC_NCEX_NO_FUNCTIONAL_TPMS = SECURE_COMP_ID | 0x28, RC_NCEX_INVALID_PHYS_PATH = SECURE_COMP_ID | 0x29, RC_NCEX_INVALID_INSTANCE_COUNT = SECURE_COMP_ID | 0x2A, - RC_NCEX_WAITING_TIMEOUT = SECURE_COMP_ID | 0x2B, + RC_NC_WAITING_TIMEOUT = SECURE_COMP_ID | 0x2B, // Reason codes 0xA0 - 0xEF reserved for trustedboot_reasoncodes.H }; |
