RTC3594: Improve SPLess Operation

- branch spless3
- reorganize command and status regs
- add seqnum
- rewrite spless handler
- add scanistepnames.pl code to extract istep names
- modify hb-simdebug.py to read istep names
- review fixes
- add workaround for vbu

Change-Id: I0f8f991ccbaa822ef5ab672279c3c206e6b7b2e3
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/523
Tested-by: Jenkins Server
Reviewed-by: Mark W. Wenning <wenning@us.ibm.com>

2 files changed, 32 insertions, 11 deletions

diff --git a/src/include/usr/initservice/initsvcstructs.H b/src/include/usr/initservice/initsvcstructs.H
index 92913eb9b..2e9644132 100644
--- a/src/include/usr/initservice/initsvcstructs.H
+++ b/src/include/usr/initservice/initsvcstructs.H
@@ -33,7 +33,9 @@
 // Includes
 /******************************************************************************/
 #include <stdint.h>
-#include <sys/vfs.h>            // VFS_MODULE_MAX
+#include <sys/vfs.h>            // VFS_MODULE_NAME_MAX
+
+#include <initservice/initsvcreasoncodes.H>
 
 
 namespace   INITSERVICE
@@ -49,6 +51,23 @@ namespace   INITSERVICE
 /******************************************************************************/
 
 /**
+ * @note    istepname tag - this is a way to call out the istep, substep, and
+ *          istep name for spless operation.    scanistepnames.pl will run
+ *          through this, find the istepnames, and publish it as a CVS file
+ *          for use by the SPLess user console (python) code.
+ *          Usage:
+ *          @ISTEPNAME( 4, 0, "init_target_states" )
+ *
+ *          This will be picked up by scanistepnames.pl and put in as the line
+ *              4,0,init_target_states
+ *
+ *          HostBoot will see it as the string "init_target_states" in the
+ *          istepNlist.H file
+ */
+#define ISTEPNAME( ISTEP, SUBSTEP, NAME )      NAME
+
+
+/**
  * @enum    TaskType
  *  - NONE          ==  placeholder, no task
  *  - INIT_TASK     ==  load and initialize task, but task has no _start()
diff --git a/src/include/usr/isteps/istep4list.H b/src/include/usr/isteps/istep4list.H
index f520452ec..4aa29e87e 100644
--- a/src/include/usr/isteps/istep4list.H
+++ b/src/include/usr/isteps/istep4list.H
@@ -28,9 +28,11 @@
  *
  *  list of functions called by HWAS (ISTEP 4) - "named isteps"
  *
+ *  Please see the note in initsvcstructs.H for description of
+ *      the ISTEPNAME macro.
+ *
  */
 
-
 #include    <initservice/initsvcstructs.H>
 #include    <initservice/initsvcreasoncodes.H>
 
@@ -60,7 +62,7 @@ namespace   INITSERVICE
 const   TaskInfo    g_istep4[]  =   {
 
         {
-                "init_target_states" ,          // substep name
+                ISTEPNAME(4,0,"init_target_states"),    // substep name
                 HWAS::init_target_states,               // pointer to fn
                 {
                         START_FN,                       // task type
@@ -69,7 +71,7 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "init_fsi" ,                    // substep name
+                ISTEPNAME(4,1,"init_fsi"),              // substep name
                 HWAS::init_fsi,                         // pointer to fn
                 {
                         START_FN,                       // task type
@@ -78,7 +80,7 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "apply_fsi_info" ,                   // substep name
+                ISTEPNAME(4,2,"apply_fsi_info"),        // substep name
                 HWAS::apply_fsi_info,                   // pointer to fn
                 {
                         START_FN,                       // task type
@@ -87,7 +89,7 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "apply_dd_presence" ,           // substep name
+                ISTEPNAME(4,3,"apply_dd_presence"),     // substep name
                 HWAS::apply_dd_presence,                // pointer to fn
                 {
                         START_FN,                       // task type
@@ -96,7 +98,7 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "apply_pr_keyword_data" ,       // substep name
+                ISTEPNAME(4,4,"apply_pr_keyword_data"), // substep name
                 HWAS::apply_pr_keyword_data,            // pointer to fn
                 {
                         START_FN,                       // task type
@@ -105,7 +107,7 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "apply_partial_bad" ,           // substep name
+                ISTEPNAME(4,5,"apply_partial_bad"),     // substep name
                 HWAS::apply_partial_bad,                // pointer to fn
                 {
                         START_FN,                       // task type
@@ -114,7 +116,7 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "apply_gard" ,                  // substep name
+                ISTEPNAME(4, 6, "apply_gard"),            // substep name
                 HWAS::apply_gard,                       // pointer to fn
                 {
                         START_FN,                       // task type
@@ -123,8 +125,8 @@ const   TaskInfo    g_istep4[]  =   {
                 }
         },
         {
-                "testHWP" ,                  // substep name
-                HWAS::testHWP,                       // pointer to fn
+                ISTEPNAME(4,7,"testHWP"),               // substep name
+                HWAS::testHWP,                          // pointer to fn
                 {
                         START_FN,                       // task type
                         EXT_IMAGE,                      // Extended Module