diff options
| author | Prachi Gupta <pragupta@us.ibm.com> | 2018-06-21 09:15:52 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-06-26 17:10:40 -0400 |
| commit | cfc5fb7993fad6ac737340b2dd1a569817dad987 (patch) | |
| tree | 4866da77a70b04536d55de7c69a88ce2aa838dd8 /src/include/usr/xscom | |
| parent | d406ad362d7f95cef1425216996f08fb5a1c7dca (diff) | |
| download | talos-hostboot-cfc5fb7993fad6ac737340b2dd1a569817dad987.tar.gz talos-hostboot-cfc5fb7993fad6ac737340b2dd1a569817dad987.zip | |
Save HRMOR in mbox scratch reg for IPC messaging
In order to know where the IPC message of a given node is,
we save off the HRMOR of every node in a hw register.
Originally, we were saving this information in the core
scratch register. Since, the core scratch registers are
wiped off when the cores go into the winkle state, therefore,
we were writing to the register after we come out of winkle.
But, at that point, we ran into race conditions because
other nodes could be ahead and try to access the register
on a node that is not exactly out of winkle yet.
This fixes the problems by using the mbox scratch register
rather than the core scratch register because they are saved
off even when the cores go into winkle state. Because the
registers are preseved, we can set the value prior to
cores coming out of winkle, so, we don't run into the race
condition where one node is trying to read a value prior to
the other one writing the value.
Change-Id: I822bfc8defe09cbb418edc5f36a99b7cd41eec88
CQ:SW435271
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61093
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/xscom')
| -rw-r--r-- | src/include/usr/xscom/xscomif.H | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/include/usr/xscom/xscomif.H b/src/include/usr/xscom/xscomif.H index e547c4621..cead10af3 100644 --- a/src/include/usr/xscom/xscomif.H +++ b/src/include/usr/xscom/xscomif.H @@ -45,13 +45,13 @@ uint64_t generate_mmio_addr( TARGETING::Target* i_proc, uint64_t i_scomAddr ); /** - * @brief Multicast Read of core XSCOM register on remote Node + * @brief Read of XSCOM register on remote Node * @param[in] i_node - logical Node Number * @param[in] i_scomAddr - Physical scom address to read * @return uint64_t - Register value */ -uint64_t readRemoteCoreScomMultiCast( uint64_t i_node, - uint64_t i_scomAddr ); +uint64_t readRemoteScom( uint64_t i_node, + uint64_t i_scomAddr ); }; // namespace XSCOM |
