diff options
| author | Tsung Yeung <tyeung@us.ibm.com> | 2018-12-20 10:39:39 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-02-12 10:50:42 -0600 |
| commit | b2027cd8b704587be6ce4dd14327e6730f9d519b (patch) | |
| tree | bf1b0206440c5105e46db51bb1a837ac71290ce9 /src/include/usr/vpd | |
| parent | 95bbfc78a463c06cd06204ee8cb1b904ec864565 (diff) | |
| download | talos-hostboot-b2027cd8b704587be6ce4dd14327e6730f9d519b.tar.gz talos-hostboot-b2027cd8b704587be6ce4dd14327e6730f9d519b.zip | |
Disable NVDIMM Trigger Before Draminit and Deassert DDR_RESETn During MPIPL
- Per the JEDEC spec, DDR_RESETn is masked from the DRAM when the NVDIMM
is armed. This could cause the training to fail if the trigger is not
disabled before training. Two scenarios where this can happen are warm
reboot and cold boot before the backup power module can deplete the
charge
- Deassert DDR_RESETn in MPIPL before triggering the restore.
- Fix the config flag to enable NVDIMM code
Change-Id: I9d25c2f653fc54d379f0dbab49218f5b59a407a0
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70035
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/vpd')
| -rw-r--r-- | src/include/usr/vpd/spdenums.H | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/include/usr/vpd/spdenums.H b/src/include/usr/vpd/spdenums.H index 9decbe862..bd6418d5e 100644 --- a/src/include/usr/vpd/spdenums.H +++ b/src/include/usr/vpd/spdenums.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2013,2016 */ +/* Contributors Listed Below - COPYRIGHT 2013,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -142,7 +142,8 @@ enum MODULE_REVISION_CODE_DDR4 = MODULE_REVISION_CODE, DRAM_STEPPING = SPD_FIRST_NORM_KEYWORD | 0x57, MANUFACTURING_SECTION_CRC = SPD_FIRST_NORM_KEYWORD | 0x58, - SPD_LAST_NORM_KEYWORD = SPD_FIRST_NORM_KEYWORD | 0x58, + NVM_INIT_TIME = SPD_FIRST_NORM_KEYWORD | 0x59, + SPD_LAST_NORM_KEYWORD = SPD_FIRST_NORM_KEYWORD | 0x59, // ============================================================== // Module Specific Keywords (Available for both DDR3 and DDR4 DIMMs) |
