diff options
| author | Mike Baiocchi <mbaiocch@us.ibm.com> | 2017-12-07 12:06:38 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-12-20 17:00:02 -0500 |
| commit | 5cd50322982059a6b71d5957e22f6f85da17404e (patch) | |
| tree | b965e3b6fa665d6347007e6e7247a7abb60a0a37 /src/include/usr/util | |
| parent | 34dbdc49d0d14933c317be2815302d0d558c5924 (diff) | |
| download | talos-hostboot-5cd50322982059a6b71d5957e22f6f85da17404e.tar.gz talos-hostboot-5cd50322982059a6b71d5957e22f6f85da17404e.zip | |
Fix Initializing HW To Point At An Invalid TCE Table in Istep 10.6
This fixes a bug where the HW was not initialized properly to
point at an invalid TCE Table in istep 10.6. This is required such
that the FSP cannot DMA into memory without Hostboot control.
Change-Id: I41ad102a4c05bfede5062f6082cbfa9041c0f1cf
RTC:168745
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/50652
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Stephen M. Cprek <smcprek@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/util')
| -rw-r--r-- | src/include/usr/util/utiltce.H | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/include/usr/util/utiltce.H b/src/include/usr/util/utiltce.H index b0aaf48ae..f77d005f8 100644 --- a/src/include/usr/util/utiltce.H +++ b/src/include/usr/util/utiltce.H @@ -56,9 +56,6 @@ namespace TCE * FSP uses the token as a DMA Address. * Each TCE entry maps to a pagesize of memory. * - * Note: First time this is called will cause TCE Table to be created and - * the Processors to be setup to point at the TCE Table - * * @return errlHndl_t - Return Error Handle if failed * */ @@ -130,6 +127,10 @@ bool utilUseTcesForDmas(void); * This prevents the FSP from using unsecure DMAs during the IPL until * Hostboot sets up the TCE Table with proper TCEs. * + * @note This API only works once and only when called before any other TCE + * Setup/Allocate functions as its logic only works the first time the + * UtilTceMgr Singleton class is created. + * * @return errlHndl_t - Return Error Handle if failed * */ |
