diff options
| author | Chen Du <duchen@us.ibm.com> | 2019-01-28 15:23:17 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-03-15 10:34:40 -0500 |
| commit | c4031acbfb0525325bc61cbb353e91acd5f3cc60 (patch) | |
| tree | 1b03ddbda31fd698e9ead0ad908cacef084c422d /src/include/usr/targeting | |
| parent | 87cc9b25b008bbd84bb56208f07cfb36bd42db24 (diff) | |
| download | talos-hostboot-c4031acbfb0525325bc61cbb353e91acd5f3cc60.tar.gz talos-hostboot-c4031acbfb0525325bc61cbb353e91acd5f3cc60.zip | |
Dropped messages at shutdown
Mailbox is needed to send attrs to FSP but it is
disabled after a shutdown request, which causes
messages to be dropped. Solution is to process messages
as normal, but after the shutdown is requested we then
ignore all future attr messages
Change-Id: I7f3cc4bea66f324ae9ab8dbffe59bf9a7a7edc87
CQ: SW448904
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71012
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/targeting')
| -rw-r--r-- | src/include/usr/targeting/attrrp.H | 23 | ||||
| -rw-r--r-- | src/include/usr/targeting/common/targreasoncodes.H | 3 |
2 files changed, 24 insertions, 2 deletions
diff --git a/src/include/usr/targeting/attrrp.H b/src/include/usr/targeting/attrrp.H index b04973230..d4aa6eaec 100644 --- a/src/include/usr/targeting/attrrp.H +++ b/src/include/usr/targeting/attrrp.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2018 */ +/* Contributors Listed Below - COPYRIGHT 2012,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -351,6 +351,10 @@ class AttrRP MSG_PRIME_ATTR_SYNC = 0x00000003, // Invoke attribute synchronization MSG_INVOKE_ATTR_SYNC = 0x00000004, + // Shutdown attribute synchronization + MSG_SHUTDOWN_ATTR_SYNC = 0x00000005, + // Attribute overrides and syncs + MSG_ATTR_OVERRIDE_SYNC = 0x00000006, // Sentinel value for when message type is not yet known MSG_INVALID = 0xFFFFFFFF, }; @@ -381,6 +385,13 @@ class AttrRP static errlHndl_t syncAllAttributesToFsp(); /** + * @brief This is a static wrapper around _sendAttrOverridesAndSyncs + * + * @see _sendAttrOverridesAndSyncs for documentation + */ + static errlHndl_t sendAttrOverridesAndSyncs(); + + /** * @brief Modifies the memory R/W permissions on VMM pages for a * given type of AttrRP_Section. Valid types can be found * in the generated file pnorheader.H. Valid permissions @@ -648,6 +659,16 @@ class AttrRP errlHndl_t _syncAllAttributesToFsp() const; /** + * @brief Send attribute overrides and sync down to FSP + * + * @return errlHndl_t Error log handle + * @retval nullptr Send attribute overrides and sync successful + * @retval !nullptr Send attribute overrides and sync failed; handle + * references valid error log + */ + errlHndl_t _sendAttrOverridesAndSyncs() const; + + /** * @brief Sends message of the given type to the attribute resource * provider * diff --git a/src/include/usr/targeting/common/targreasoncodes.H b/src/include/usr/targeting/common/targreasoncodes.H index c5e2882f8..419248b1b 100644 --- a/src/include/usr/targeting/common/targreasoncodes.H +++ b/src/include/usr/targeting/common/targreasoncodes.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2018 */ +/* Contributors Listed Below - COPYRIGHT 2012,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -84,6 +84,7 @@ enum TargetingReasonCode TARG_RC_CONCURRENT_CODE_UPDATE_FAIL = TARG_COMP_ID | 0x18, TARG_RC_ATTR_OVER_FAPI_TANK_NOT_SUPPORTED = TARG_COMP_ID | 0x19, TARG_RC_UNSUPPORTED_ATTR_SYNC_MSG = TARG_COMP_ID | 0x1A, + TARG_RC_ATTR_SYNC_SERVICE_DOWN = TARG_COMP_ID | 0x1B, }; }; // End TARGETING namespace |
