diff options
author | Brian Horton <brianh@linux.ibm.com> | 2012-04-25 15:48:55 -0500 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-05-08 17:20:50 -0500 |
commit | cd9263254cacd7948aad8ba1bd3a98af469b02af (patch) | |
tree | 26e6c8a9856ac9d5b782173b1f2df9b35fe53e18 /src/include/usr/targeting/common | |
parent | 8c8f1b51f8f7d366e60ce8ae899b77cd122f86f4 (diff) | |
download | talos-hostboot-cd9263254cacd7948aad8ba1bd3a98af469b02af.tar.gz talos-hostboot-cd9263254cacd7948aad8ba1bd3a98af469b02af.zip |
Errlog User Details: Log Arbitrary Attributes
Add code so that a hostboot or procedure developer can save attributes
into an error log and have them display in a human-readable way in order
to aid debug and FA. All data is stored in errlog in binary format and
decoded into strings and enum 'constants' with the parse function.
Methods to dump and parse the attributes are auto-generated by the
xmltohb.pl script.
In addition, cleanup up Target User Details so that blanks lines aren't
output and so that the attribute name isn't put into the error log and
is instead added by the parse function (smaller errlog usage), and change
to same coding style as other UserDetail functions (data put into buffer
in ctor and not in addToLog function).
following will be added in future story/task work:
- parsing for complex attributes.
- combining multiple attribute user details together instead of
generating a separate log entry for each.
Change-Id: I6baafa36ef095aafabb5bf86d6054bcb3db47019
RTC: 35275
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/944
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Tested-by: Jenkins Server
Diffstat (limited to 'src/include/usr/targeting/common')
-rw-r--r-- | src/include/usr/targeting/common/target.H | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/include/usr/targeting/common/target.H b/src/include/usr/targeting/common/target.H index d91483cad..bd37b8a01 100644 --- a/src/include/usr/targeting/common/target.H +++ b/src/include/usr/targeting/common/target.H @@ -249,7 +249,7 @@ class Target * * @post caller must call free() to release the buffer */ - char * targetFFDC( uint32_t & o_size ) const; + uint8_t * targetFFDC( uint32_t & o_size ) const; private: // Private helper interfaces |