diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2018-02-22 09:59:11 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-24 21:42:48 -0500 |
| commit | 431a3cc0aa10884e9f9f27a12c6d1c97206bc83a (patch) | |
| tree | e8361b4da7d862f05141536537854ae3ee162241 /src/include/usr/targeting/common | |
| parent | 24bc6a1bee514ae580733f1695c7d82edc4da4cb (diff) | |
| download | talos-hostboot-431a3cc0aa10884e9f9f27a12c6d1c97206bc83a.tar.gz talos-hostboot-431a3cc0aa10884e9f9f27a12c6d1c97206bc83a.zip | |
Bug fixes for concurrent update of HBRT
Fixed a bug where the wrong copy of the attribute was being used
after our code update preparation was run.
Fixed a bug due to not having enough memory allocated to update
the attribute values during the transition.
Added space to initial reserved memory to allow for new
attributes to be added at runtime.
Change-Id: I97c4d20ff1c369398be470fef718bbd001f71c1b
CQ: SW417526
ForwardPort: yes
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54685
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/targeting/common')
| -rw-r--r-- | src/include/usr/targeting/common/target.H | 16 | ||||
| -rw-r--r-- | src/include/usr/targeting/common/targreasoncodes.H | 2 |
2 files changed, 10 insertions, 8 deletions
diff --git a/src/include/usr/targeting/common/target.H b/src/include/usr/targeting/common/target.H index cc5f4a1f1..7bdd16f54 100644 --- a/src/include/usr/targeting/common/target.H +++ b/src/include/usr/targeting/common/target.H @@ -55,12 +55,16 @@ // Forward declarations to allow friend functions to work //****************************************************************************** #ifdef __HOSTBOOT_RUNTIME +namespace ERRORLOG +{ + class ErrlEntry; +} namespace RT_TARG { void adjustTargeting4Runtime(); - int saveRestoreAttrs(void *i_rsvdMemPtr, - void *io_lidStructPtr, - uint64_t& o_userdata2); + ERRORLOG::ErrlEntry* saveRestoreAttrs(void *i_rsvdMemPtr, + void *io_lidStructPtr, + uint64_t& o_userdata2); } #endif @@ -698,9 +702,9 @@ class Target #ifdef __HOSTBOOT_RUNTIME friend void RT_TARG::adjustTargeting4Runtime(); - friend int RT_TARG::saveRestoreAttrs(void *, - void *, - uint64_t&); + friend ERRORLOG::ErrlEntry* RT_TARG::saveRestoreAttrs(void *, + void *, + uint64_t&); #endif diff --git a/src/include/usr/targeting/common/targreasoncodes.H b/src/include/usr/targeting/common/targreasoncodes.H index f7bcdbc6b..6e21afd8c 100644 --- a/src/include/usr/targeting/common/targreasoncodes.H +++ b/src/include/usr/targeting/common/targreasoncodes.H @@ -50,7 +50,6 @@ enum TargetingModuleId TARG_APPLY_ATTR_OVER = 0x0A, TARG_HANDLE_ENUM_CHECK_FAILURE = 0x0B, TARG_HANDLE_RANGE_CHECK_FAILURE = 0x0C, - TARG_RT_HBRT_UPDATE_PREP = 0x0D, }; enum TargetingReasonCode @@ -78,7 +77,6 @@ enum TargetingReasonCode TARG_RC_MM_BLOCK_UNMAP_FAIL = TARG_COMP_ID | 0x15, TARG_RC_ATTRIBUTE_ENUM_CHECK_FAIL = TARG_COMP_ID | 0x16, TARG_RC_ATTRIBUTE_RANGE_CHECK_FAIL = TARG_COMP_ID | 0x17, - TARG_RC_CONCURRENT_CODE_UPDATE_FAIL = TARG_COMP_ID | 0x18, }; }; // End TARGETING namespace |
