diff options
| author | Roland Veloz <rveloz@us.ibm.com> | 2019-06-11 12:41:40 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-06-12 13:35:26 -0500 |
| commit | 9192b12a33dc07d4a4f3d88c323ac373dd8f6367 (patch) | |
| tree | be3f1d39bbb75fefeb4129a69c7247bfc594c7e6 /src/include/usr/runtime | |
| parent | 12ef1ffdc34ad61b2442f369163fbef55c8a8802 (diff) | |
| download | talos-hostboot-9192b12a33dc07d4a4f3d88c323ac373dd8f6367.tar.gz talos-hostboot-9192b12a33dc07d4a4f3d88c323ac373dd8f6367.zip | |
Reworked the AttributeTank::Attribute API
Once I made the Attribute structure public, I exposed the API.
It was no longer sufferance to allow users to just modify the properties
of the structure openly. It was time to encapsulate the data and
provide a proper API.
Removed the 'virtual' keyword from the class AttributeTank. This
class is not being used polymorphically any where, therefore the
keyword 'virtual' was just adding to it's memory size foot print
for no reason.
Change-Id: I073aa5dbef1eba911afb95392de5e580f6aac100
RTC:208343
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78756
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Zachary Clark <zach@ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/runtime')
| -rw-r--r-- | src/include/usr/runtime/runtime_reasoncodes.H | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/include/usr/runtime/runtime_reasoncodes.H b/src/include/usr/runtime/runtime_reasoncodes.H index 735a4ec6c..7aa6a114d 100644 --- a/src/include/usr/runtime/runtime_reasoncodes.H +++ b/src/include/usr/runtime/runtime_reasoncodes.H @@ -141,6 +141,8 @@ namespace RUNTIME RC_SP_ATTN_AREA1_SIZE_OVERFLOW = RUNTIME_COMP_ID | 0x43, RC_UNKNOWN_LABEL = RUNTIME_COMP_ID | 0x44, RC_NULL_FIRMWARE_MSG_PTR = RUNTIME_COMP_ID | 0x45, + RC_SERIALIZE_ATTRIBUTE_FAILED = RUNTIME_COMP_ID | 0x46, + RC_NO_SPACE_FOR_ATTRIBUTE_SERIALIZATION = RUNTIME_COMP_ID | 0x47, }; enum UserDetailsTypes |
