diff options
author | Ilya Smirnov <ismirno@us.ibm.com> | 2018-01-26 12:10:24 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-14 15:01:31 -0500 |
commit | d9c127dca8312f119b379c83b361216b910f6748 (patch) | |
tree | 8d37e7926981c115092a558daf36d8d02d405ae2 /src/include/usr/runtime/runtime_reasoncodes.H | |
parent | ddfe08755562f0bd6b2ec445972f4b2c751a5f80 (diff) | |
download | talos-hostboot-d9c127dca8312f119b379c83b361216b910f6748.tar.gz talos-hostboot-d9c127dca8312f119b379c83b361216b910f6748.zip |
Error when hb tries to access reserved memory past limit
An issue has recently occurred when hb reserved memory past
the allowed limit (256M-4K) and overwrote some of the PHYP
memory, which caused bugs that were difficult to debug. This
change is to check the memory address we are trying to reserve
and throw an error if the address is at or above the allowed
limit. We only execute this check if PHYP is running and only
on components not belonging to PHYP (PHYP components may be
placed outside of the limit).
Change-Id: Ic62a7b724abc3b29b7872d0af47de8c68cde2ea8
RTC:186332
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52850
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/runtime/runtime_reasoncodes.H')
-rw-r--r-- | src/include/usr/runtime/runtime_reasoncodes.H | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/include/usr/runtime/runtime_reasoncodes.H b/src/include/usr/runtime/runtime_reasoncodes.H index 19799c51a..3937e553f 100644 --- a/src/include/usr/runtime/runtime_reasoncodes.H +++ b/src/include/usr/runtime/runtime_reasoncodes.H @@ -62,6 +62,7 @@ namespace RUNTIME MOD_RT_FIRMWARE_NOTIFY = 0x23, /**< rt_fwnotify.C */ MOD_RT_FIRMWARE_REQUEST = 0x24, /**< rt_fwreq_helper.C */ MOD_RT_ATTR_SYNC_REQUEST = 0x25, /**< rt_fwnotify.C */ + MOD_CHECK_HB_RES_MEM_LIMIT = 0x26, /**<populate_hbruntime.C */ }; enum RuntimeReasonCode @@ -127,6 +128,7 @@ namespace RUNTIME RC_TPM_HDAT_VIRT_TO_PHYS_ERR = RUNTIME_COMP_ID | 0x3A, RC_TPM_HDAT_MAP_BLOCK_ERR = RUNTIME_COMP_ID | 0x3B, RC_ATTR_UPDATE_FAILED = RUNTIME_COMP_ID | 0x3C, + RC_HB_RES_MEM_EXCEEDED = RUNTIME_COMP_ID | 0x3D, }; enum UserDetailsTypes |