diff options
| author | Mike Jones <mjjones@us.ibm.com> | 2012-12-13 08:19:18 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-12-13 15:37:59 -0600 |
| commit | ca57ac8f1561d676497397d03f25bf942ea75b85 (patch) | |
| tree | 5d4645a3576ddf75288acd5d8604fe5efefe024a /src/include/usr/hwpf | |
| parent | fa8513c5a50a4632b21c7480f15a671b0cc62fdd (diff) | |
| download | talos-hostboot-ca57ac8f1561d676497397d03f25bf942ea75b85.tar.gz talos-hostboot-ca57ac8f1561d676497397d03f25bf942ea75b85.zip | |
HWPF Attr Override/Sync: Fix mailbox queue id and minor review updates
After merging the HWSV side of the HWPF Attr Override/Sync change. I
found that someone stole my queue ids. Updating the Hostboot code to
match. Also some minor changes to some FAPI files that Nick wanted
done after the HWSV review.
Change-Id: I6b3724ab2aa3234794112b098c74914b16e1a69a
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/2676
Tested-by: Jenkins Server
Reviewed-by: Brian H. Horton <brianh@linux.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/include/usr/hwpf')
| -rw-r--r-- | src/include/usr/hwpf/fapi/fapiAttributeTank.H | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/src/include/usr/hwpf/fapi/fapiAttributeTank.H b/src/include/usr/hwpf/fapi/fapiAttributeTank.H index 1a666e8cf..a353c5e3f 100644 --- a/src/include/usr/hwpf/fapi/fapiAttributeTank.H +++ b/src/include/usr/hwpf/fapi/fapiAttributeTank.H @@ -73,6 +73,11 @@ const uint8_t ATTR_ARRAYD_NA = 0xff; // iv_arrayDX not applicable */ struct Attribute { + /** + * @brief Constructor initializes default values + */ + Attribute(); + uint64_t iv_val; // Value of attribute. uint32_t iv_attrId; // fapi::AttributeId enum value uint32_t iv_targetType; // fapi::TargetType enum value @@ -98,6 +103,11 @@ struct AttributeChunk static const size_t MAX_CHUNK_SIZE_BYTES = 4096; static const size_t MAX_ATTRS_PER_CHUNK = MAX_CHUNK_SIZE_BYTES / sizeof(Attribute); + + /** + * @brief Constructor initializes default values + */ + AttributeChunk(); size_t iv_numAttributes; // Number of Attributes in chunk uint8_t * iv_pAttributes; // Pointer to chunk of memory }; @@ -227,7 +237,7 @@ public: * or delete[] (if NEW) each chunk's memory */ virtual void getAllAttributes( - AllocType i_allocType, + const AllocType i_allocType, std::vector<AttributeChunk> & o_attributes) const; /** |
