diff options
author | Matthew Raybuck <matthew.raybuck@ibm.com> | 2019-02-26 14:46:10 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-03-18 15:43:46 -0500 |
commit | 3265b62f038c0e91d0f22cde3e95f9b9076cb6fa (patch) | |
tree | 8885af5dc78eca2cccd57dfb4f8e2054c4d60f99 /src/include/usr/hwas/common/pgLogic.H | |
parent | e0f03516109881263fe86fc97d42d3ec6ae75155 (diff) | |
download | talos-hostboot-3265b62f038c0e91d0f22cde3e95f9b9076cb6fa.tar.gz talos-hostboot-3265b62f038c0e91d0f22cde3e95f9b9076cb6fa.zip |
Improve performance of general PG algorithm
The previous PG algorithm had several places where targets would be
rechecked or modified unnecessarily. This commit restructures the PG
algorithm and pulls all related code out of discoverTargets and adds it
to checkPartialGoodForDescendants which will be called by
discoverTargets.
Change-Id: I045f17f7ac22c673633cd3d951997b2371be1b8d
RTC:206066
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72732
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/usr/hwas/common/pgLogic.H')
-rw-r--r-- | src/include/usr/hwas/common/pgLogic.H | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/include/usr/hwas/common/pgLogic.H b/src/include/usr/hwas/common/pgLogic.H index 1adf5509f..8e1ca32ba 100644 --- a/src/include/usr/hwas/common/pgLogic.H +++ b/src/include/usr/hwas/common/pgLogic.H @@ -695,14 +695,14 @@ namespace PARTIAL_GOOD APPLICABLE_TO_ALL, NO_SPECIAL_RULE ), - // OBUS Rule 3: pbioo1 unit on chiplet N3 must be checked + // OBUS Rule 3: pbioo1 unit on chiplet N1 must be checked // for Cumulus OBUSes (chip unit 1 and 2). new PartialGoodRule ( {&PREDICATE_CUMULUS}, OBUS_R3_PG_MASK, ALL_OFF_AG_MASK, - N3_PG_INDEX, + N1_PG_INDEX, OBUS_R3_CU_MASK, NO_SPECIAL_RULE ), |