diff options
author | Brian Horton <brianh@linux.ibm.com> | 2012-08-01 16:34:47 -0500 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2012-09-05 15:18:42 -0500 |
commit | 348e054c2d70697169a4ecbdc2eaab1932bd322c (patch) | |
tree | 2aab9491574d337151633861852e1f400621cea6 /src/include/usr/errl | |
parent | 53643b771cfa77708539de18b5fc9a2a4b19a141 (diff) | |
download | talos-hostboot-348e054c2d70697169a4ecbdc2eaab1932bd322c.tar.gz talos-hostboot-348e054c2d70697169a4ecbdc2eaab1932bd322c.zip |
Performance and size optimizations - inline simple methods
Move the code for some of the 'simple' methods (ie, {}, or simple
methods that just set a value or return a value) from the .C file
into the .H file, so that they're inlined. Saves in both size and
performance. Didn't measure performance gains (not sure I can in a
simulated environment..) but generated .list files look much better.
Size - hbicore_extended.bin dropped from 1442928 to 1426544 (16K, 1%)
Change-Id: I6915cba77520b4a28237c557760ababcca781804
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/1464
Tested-by: Jenkins Server
Reviewed-by: MIKE J. JONES <mjjones@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Diffstat (limited to 'src/include/usr/errl')
-rw-r--r-- | src/include/usr/errl/errlentry.H | 66 |
1 files changed, 37 insertions, 29 deletions
diff --git a/src/include/usr/errl/errlentry.H b/src/include/usr/errl/errlentry.H index b3255a55b..bc9d8a32a 100644 --- a/src/include/usr/errl/errlentry.H +++ b/src/include/usr/errl/errlentry.H @@ -1,26 +1,25 @@ -/* IBM_PROLOG_BEGIN_TAG - * This is an automatically generated prolog. - * - * $Source: src/include/usr/errl/errlentry.H $ - * - * IBM CONFIDENTIAL - * - * COPYRIGHT International Business Machines Corp. 2011-2012 - * - * p1 - * - * Object Code Only (OCO) source materials - * Licensed Internal Code Source Materials - * IBM HostBoot Licensed Internal Code - * - * The source code for this program is not published or other- - * wise divested of its trade secrets, irrespective of what has - * been deposited with the U.S. Copyright Office. - * - * Origin: 30 - * - * IBM_PROLOG_END_TAG - */ +/* IBM_PROLOG_BEGIN_TAG */ +/* This is an automatically generated prolog. */ +/* */ +/* $Source: src/include/usr/errl/errlentry.H $ */ +/* */ +/* IBM CONFIDENTIAL */ +/* */ +/* COPYRIGHT International Business Machines Corp. 2011,2012 */ +/* */ +/* p1 */ +/* */ +/* Object Code Only (OCO) source materials */ +/* Licensed Internal Code Source Materials */ +/* IBM HostBoot Licensed Internal Code */ +/* */ +/* The source code for this program is not published or otherwise */ +/* divested of its trade secrets, irrespective of what has been */ +/* deposited with the U.S. Copyright Office. */ +/* */ +/* Origin: 30 */ +/* */ +/* IBM_PROLOG_END_TAG */ #ifndef ERRLENTRY_H #define ERRLENTRY_H /** @@ -143,7 +142,7 @@ public: * @return Current Log Severity * */ - errlSeverity_t sev() const; + errlSeverity_t sev() const { return iv_User.iv_severity; } /** @@ -157,7 +156,10 @@ public: * * @return void */ - void setSev(const errlSeverity_t i_sev); + void setSev(const errlSeverity_t i_sev) + { + iv_User.iv_severity = i_sev; + } /** @@ -216,7 +218,7 @@ public: * @return errlEventType_t * */ - errlEventType_t eventType() const; + errlEventType_t eventType() const { return iv_User.iv_etype; } /** * @brief Set the log's event type @@ -226,7 +228,10 @@ public: * @return void * */ - void setEventType(const errlEventType_t i_eventType); + void setEventType(const errlEventType_t i_eventType) + { + iv_User.iv_etype = i_eventType; + } /** * @brief Returns the log's sub system. See errl/errltypes.H @@ -234,7 +239,7 @@ public: * @return epubSubSystem_t * */ - epubSubSystem_t subSys() const; + epubSubSystem_t subSys() const { return iv_User.iv_ssid; } /** * @brief Set the log's ePub sub system type. @@ -243,7 +248,10 @@ public: * * @return void */ - void setSubSys(const epubSubSystem_t i_subSys); + void setSubSys(const epubSubSystem_t i_subSys) + { + iv_User.iv_ssid = i_subSys; + } /** |