diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-02-12 14:59:05 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-02-19 09:43:09 -0500 |
| commit | 8d28433bcc3c927ee76cdc4231099660545b1bfa (patch) | |
| tree | c6f3810c0b2d69a55d8309ae1c35a8c1c7fdf5c1 /src/include/runtime | |
| parent | 28927a78ca4144aa8214d35b7ad7e2ddba5ada4e (diff) | |
| download | talos-hostboot-8d28433bcc3c927ee76cdc4231099660545b1bfa.tar.gz talos-hostboot-8d28433bcc3c927ee76cdc4231099660545b1bfa.zip | |
Fix bugs in FSP->HBRT message path for SBE errors
Hostboot was expecting the incorrect order of data in messages sent
from the FSP -> PHYP -> HBRT where the SBE is requesting that HBRT
reset the SBE. This commit corrects the order and renames the struct
for the specific role its used in. Also this commit fixes the values
for the MESSAGE type sent by the FSP.
CQ: SW415675
Change-Id: I08f44486054e7d0113fd7606bb40ced577080d0c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53883
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/include/runtime')
| -rw-r--r-- | src/include/runtime/generic_hbrt_fsp_message.H | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/include/runtime/generic_hbrt_fsp_message.H b/src/include/runtime/generic_hbrt_fsp_message.H index 0f28b5640..102e2692b 100644 --- a/src/include/runtime/generic_hbrt_fsp_message.H +++ b/src/include/runtime/generic_hbrt_fsp_message.H @@ -65,12 +65,12 @@ struct TargetDeconfigHbrtFspData_t /** * A useful struct to access the PLID from GenericFspMboxMessage_t.data - * The PLID will be in the first 4 bytes followed by some other data. + * in the case where the FSP is requesting Hostboot to restart a SBE */ -struct HbrtFspData_t +struct SbeRetryReqData_t { + uint32_t huid; uint32_t plid; - uint32_t userData; } PACKED ; @@ -139,9 +139,9 @@ struct GenericFspMboxMessage_t MSG_TOD_TOPOLOGY_DATA = 0x0003, MSG_DECONFIG_TARGET = 0x0004, MSG_ATTR_SYNC_REQUEST = 0x000000A5, - MSG_SBE_ERROR = 0x000000E1, - MSG_SBE_RECOVERY_SUCCESS = 0x000000E2, - MSG_SBE_RECOVERY_FAILED = 0x000000E3, + MSG_SBE_ERROR = 0x000000D4, + MSG_SBE_RECOVERY_SUCCESS = 0x000000D5, + MSG_SBE_RECOVERY_FAILED = 0x000000D6, }; /** |
