Changed the generic message type from MSG_DECONFIG_TARGET to MSG_ATTR_WRITE_OP

Was using the wrong type.  MSG_ATTR_WRITE_OP is the correct type.

Also dropped the assertion.  From what I understand it was a nice to have
not a necessity.  Dropped because it was prohibiting the unit from running.

Change-Id: I7127b3a316092b2dd155dda0a6aa3ccfdac8fa0a
RTC:208343
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78918
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 3 insertions, 5 deletions

diff --git a/src/include/runtime/hbrt_utilities.H b/src/include/runtime/hbrt_utilities.H
index 1764dedb1..8068a6b7a 100644
--- a/src/include/runtime/hbrt_utilities.H
+++ b/src/include/runtime/hbrt_utilities.H
@@ -189,10 +189,6 @@ errlHndl_t sendAttributes(const std::vector<TARGETING::AttributeTank::Attribute>
             break;
         }
 
-        // Make sure mbox is available
-        assert(INITSERVICE::spBaseServicesEnabled(),
-               "ERROR: Cannot perform request 'sendAttributes', mbox is not available");
-
         // Make sure we have all of our function pointers setup right
         if ((nullptr == g_hostInterfaces) ||
             (nullptr == g_hostInterfaces->firmware_request))
@@ -270,7 +266,7 @@ errlHndl_t sendAttributes(const std::vector<TARGETING::AttributeTank::Attribute>
         // Populate the 'message queue' and 'message type' for this message
         l_fwRequestMsg->generic_msg.msgq = MBOX::FSP_NVDIMM_KEYS_MSGQ_ID;
         l_fwRequestMsg->generic_msg.msgType =
-                                  GenericFspMboxMessage_t::MSG_DECONFIG_TARGET;
+                                  GenericFspMboxMessage_t::MSG_ATTR_WRITE_OP;
 
         // Create a useful struct to populate the generic_msg::data field
         AttributeSetter_t* l_attributeSetter =
@@ -288,6 +284,8 @@ errlHndl_t sendAttributes(const std::vector<TARGETING::AttributeTank::Attribute>
         // Create a useful struct to poulate attribute data
         uint8_t* l_attributeData = l_attributeSetter->iv_attrData;
         uint32_t l_sizeOfDataCopied(0);
+
+        // Iterate thru the attribute list and serialize the attributes
         for (const auto & l_attribute: i_attributeList)
         {
             if (l_aggregatedAttributeSize >= l_attribute.getSize())