Updating VPD XML descriptions

Change-Id: I24b23736fea1ad8d05b475413da2951f4a3ff26a
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35006
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35018
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>

2 files changed, 46 insertions, 28 deletions

diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H
index 73ae873ae..1f9fa92a4 100644
--- a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H
+++ b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors.H
@@ -26037,8 +26037,10 @@ fapi_try_exit:
 /// @param[out] uint8_t* memory to store the value
 /// @note Generated by gen_accessors.pl generateParameters (A)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
-/// @note  READ, On Die Termination triggering
-/// bitmap.
+/// @note  READ, On Die Termination triggering bitmap. Use bitmap to determine which ODT to
+/// fire for the designated rank. The bits in 8 bit field are [Dimm0 ODT0][Dimm0
+/// ODT1][N/A][N/A][Dimm1 ODT0][Dimm1
+/// ODT1][N/A][N/A]
 ///
 inline fapi2::ReturnCode vpd_mt_odt_rd(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, uint8_t* o_array)
 {
@@ -26068,8 +26070,10 @@ fapi_try_exit:
 /// @param[out] uint8_t* memory to store the value
 /// @note Generated by gen_accessors.pl generateParameters (B)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
-/// @note  READ, On Die Termination triggering
-/// bitmap.
+/// @note  READ, On Die Termination triggering bitmap. Use bitmap to determine which ODT to
+/// fire for the designated rank. The bits in 8 bit field are [Dimm0 ODT0][Dimm0
+/// ODT1][N/A][N/A][Dimm1 ODT0][Dimm1
+/// ODT1][N/A][N/A]
 ///
 inline fapi2::ReturnCode vpd_mt_odt_rd(const fapi2::Target<fapi2::TARGET_TYPE_MCA>& i_target, uint8_t* o_array)
 {
@@ -26098,8 +26102,10 @@ fapi_try_exit:
 /// @param[out] uint8_t* memory to store the value
 /// @note Generated by gen_accessors.pl generateParameters (C)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
-/// @note  READ, On Die Termination triggering
-/// bitmap.
+/// @note  READ, On Die Termination triggering bitmap. Use bitmap to determine which ODT to
+/// fire for the designated rank. The bits in 8 bit field are [Dimm0 ODT0][Dimm0
+/// ODT1][N/A][N/A][Dimm1 ODT0][Dimm1
+/// ODT1][N/A][N/A]
 ///
 inline fapi2::ReturnCode vpd_mt_odt_rd(const fapi2::Target<fapi2::TARGET_TYPE_MCS>& i_target, uint8_t* o_array)
 {
@@ -26127,8 +26133,10 @@ fapi_try_exit:
 /// @param[out] uint8_t* memory to store the value
 /// @note Generated by gen_accessors.pl generateParameters (A)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
-/// @note  WRITE, On Die Termination triggering
-/// bitmap.
+/// @note  WRITE, On Die Termination triggering bitmap. Use bitmap to determine which ODT
+/// to fire for the designated rank. The bits in 8 bit field are [Dimm0 ODT0][Dimm0
+/// ODT1][N/A][N/A][Dimm1 ODT0][Dimm1
+/// ODT1][N/A][N/A]
 ///
 inline fapi2::ReturnCode vpd_mt_odt_wr(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, uint8_t* o_array)
 {
@@ -26158,8 +26166,10 @@ fapi_try_exit:
 /// @param[out] uint8_t* memory to store the value
 /// @note Generated by gen_accessors.pl generateParameters (B)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
-/// @note  WRITE, On Die Termination triggering
-/// bitmap.
+/// @note  WRITE, On Die Termination triggering bitmap. Use bitmap to determine which ODT
+/// to fire for the designated rank. The bits in 8 bit field are [Dimm0 ODT0][Dimm0
+/// ODT1][N/A][N/A][Dimm1 ODT0][Dimm1
+/// ODT1][N/A][N/A]
 ///
 inline fapi2::ReturnCode vpd_mt_odt_wr(const fapi2::Target<fapi2::TARGET_TYPE_MCA>& i_target, uint8_t* o_array)
 {
@@ -26188,8 +26198,10 @@ fapi_try_exit:
 /// @param[out] uint8_t* memory to store the value
 /// @note Generated by gen_accessors.pl generateParameters (C)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
-/// @note  WRITE, On Die Termination triggering
-/// bitmap.
+/// @note  WRITE, On Die Termination triggering bitmap. Use bitmap to determine which ODT
+/// to fire for the designated rank. The bits in 8 bit field are [Dimm0 ODT0][Dimm0
+/// ODT1][N/A][N/A][Dimm1 ODT0][Dimm1
+/// ODT1][N/A][N/A]
 ///
 inline fapi2::ReturnCode vpd_mt_odt_wr(const fapi2::Target<fapi2::TARGET_TYPE_MCS>& i_target, uint8_t* o_array)
 {
@@ -26218,10 +26230,11 @@ fapi_try_exit:
 /// @note Generated by gen_accessors.pl generateParameters (D)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
 /// @note  Number of clocks used for read/write preamble. Calibration only uses 1 nCK
-/// preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option. "0" means
-/// 1 nCK preamble, "1" means 2 nCK preamble. Bit 3 for READ preamble, and Bit 7 for
-/// WRITE preamble. E.g. 0b
-/// 00010001
+/// preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option. The value
+/// of "0" means 1 nCK preamble, the value of "1" means 2 nCK preamble. Bit 3 for
+/// READ preamble, and Bit 7 for WRITE preamble. E.g. 0b00010001 means 2 nCK
+/// preamble for both READ and
+/// WRITE
 ///
 inline fapi2::ReturnCode vpd_mt_preamble(const fapi2::Target<fapi2::TARGET_TYPE_MCA>& i_target, uint8_t& o_value)
 {
@@ -26244,10 +26257,11 @@ fapi_try_exit:
 /// @note Generated by gen_accessors.pl generateParameters (D.1)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
 /// @note  Number of clocks used for read/write preamble. Calibration only uses 1 nCK
-/// preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option. "0" means
-/// 1 nCK preamble, "1" means 2 nCK preamble. Bit 3 for READ preamble, and Bit 7 for
-/// WRITE preamble. E.g. 0b
-/// 00010001
+/// preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option. The value
+/// of "0" means 1 nCK preamble, the value of "1" means 2 nCK preamble. Bit 3 for
+/// READ preamble, and Bit 7 for WRITE preamble. E.g. 0b00010001 means 2 nCK
+/// preamble for both READ and
+/// WRITE
 ///
 inline fapi2::ReturnCode vpd_mt_preamble(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target, uint8_t& o_value)
 {
@@ -26271,10 +26285,11 @@ fapi_try_exit:
 /// @note Generated by gen_accessors.pl generateParameters (E)
 /// @return fapi2::ReturnCode - FAPI2_RC_SUCCESS iff get is OK
 /// @note  Number of clocks used for read/write preamble. Calibration only uses 1 nCK
-/// preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option. "0" means
-/// 1 nCK preamble, "1" means 2 nCK preamble. Bit 3 for READ preamble, and Bit 7 for
-/// WRITE preamble. E.g. 0b
-/// 00010001
+/// preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option. The value
+/// of "0" means 1 nCK preamble, the value of "1" means 2 nCK preamble. Bit 3 for
+/// READ preamble, and Bit 7 for WRITE preamble. E.g. 0b00010001 means 2 nCK
+/// preamble for both READ and
+/// WRITE
 ///
 inline fapi2::ReturnCode vpd_mt_preamble(const fapi2::Target<fapi2::TARGET_TYPE_MCS>& i_target, uint8_t* o_array)
 {
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/memory_mt_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/memory_mt_attributes.xml
index 1448180d5..bfa10c003 100644
--- a/src/import/chips/p9/procedures/xml/attribute_info/memory_mt_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/memory_mt_attributes.xml
@@ -5,7 +5,7 @@
 <!--                                                                        -->
 <!-- OpenPOWER HostBoot Project                                             -->
 <!--                                                                        -->
-<!-- Contributors Listed Below - COPYRIGHT 2016                             -->
+<!-- Contributors Listed Below - COPYRIGHT 2016,2017                        -->
 <!-- [+] International Business Machines Corp.                              -->
 <!--                                                                        -->
 <!--                                                                        -->
@@ -436,7 +436,8 @@
         <id>ATTR_MSS_VPD_MT_ODT_RD</id>
         <targetType>TARGET_TYPE_MCS</targetType>
         <description>
-            READ, On Die Termination triggering bitmap.
+            READ, On Die Termination triggering bitmap. Use bitmap to determine which ODT to fire for the designated rank.
+            The bits in 8 bit field are [Dimm0 ODT0][Dimm0 ODT1][N/A][N/A][Dimm1 ODT0][Dimm1 ODT1][N/A][N/A]
         </description>
         <initToZero></initToZero>
         <valueType>uint8</valueType>
@@ -452,7 +453,8 @@
         <id>ATTR_MSS_VPD_MT_ODT_WR</id>
         <targetType>TARGET_TYPE_MCS</targetType>
         <description>
-            WRITE, On Die Termination triggering bitmap.
+            WRITE, On Die Termination triggering bitmap. Use bitmap to determine which ODT to fire for the designated rank.
+            The bits in 8 bit field are [Dimm0 ODT0][Dimm0 ODT1][N/A][N/A][Dimm1 ODT0][Dimm1 ODT1][N/A][N/A]
         </description>
         <initToZero></initToZero>
         <valueType>uint8</valueType>
@@ -469,7 +471,8 @@
         <targetType>TARGET_TYPE_MCS</targetType>
         <description>
             Number of clocks used for read/write preamble. Calibration only uses 1 nCK preamble (DEFAULT). Mainline has both 1 nCK and 2 nCK preamble option.
-            "0" means 1 nCK preamble, "1" means 2 nCK preamble. Bit 3 for READ preamble, and Bit 7 for WRITE preamble. E.g. 0b 00010001
+            The value of "0" means 1 nCK preamble, the value of "1" means 2 nCK preamble. Bit 3 for READ preamble, and Bit 7 for WRITE preamble.
+            E.g. 0b00010001 means 2 nCK preamble for both READ and WRITE
         </description>
         <initToZero></initToZero>
         <valueType>uint8</valueType>