summaryrefslogtreecommitdiffstats
path: root/src/import/hwpf
diff options
context:
space:
mode:
authorDan Crowell <dcrowell@us.ibm.com>2018-11-09 12:28:05 -0600
committerNicholas E. Bofferding <bofferdn@us.ibm.com>2018-11-13 21:51:11 -0600
commit9d418f5eefe35bd533928cff03822943dcb7852e (patch)
treeb851c690ccd7953bf7a9c7b0fe1d9bbe95882d62 /src/import/hwpf
parent1aae1ba2930ceb5d72b9855c8003c1d8371c0791 (diff)
downloadtalos-hostboot-9d418f5eefe35bd533928cff03822943dcb7852e.tar.gz
talos-hostboot-9d418f5eefe35bd533928cff03822943dcb7852e.zip
Add missing mutex in LPC error path
There is a pre-check to look for errors before every LPC read or write operation. This check was running outside of the mutex, which meant that if an operation caused an error and then another thread attempted a separate LPC op, the second thread would end up reporting the error from the first operation, This would typically just result in a double log, but there are cases where an error is expected (the SIO problem for the hiomap protocol) and is deleted by the caller. Because of the second thread seeing the error, the error condition ends up being a visible log. The change here is to move the pre-check inside the mutex so that only 1 thread can ever be checking the LPC status at a time. Change-Id: I9ce0ce48252b7d2b271aa5dd6e0a819dfb728a25 CQ: SW450825 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68609 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Diffstat (limited to 'src/import/hwpf')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud