diff options
author | Roland Veloz <rveloz@us.ibm.com> | 2019-05-01 16:56:37 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-05-07 09:01:37 -0500 |
commit | 8d9dc76256f537bdb6d445138efa749d520aa80f (patch) | |
tree | 7524c263d8c0962e4a2de4e29a1b6e848a4b9f4d /src/import/hwpf | |
parent | d935c5c94a9e1c23325f3dcd4ed113a6985412db (diff) | |
download | talos-hostboot-8d9dc76256f537bdb6d445138efa749d520aa80f.tar.gz talos-hostboot-8d9dc76256f537bdb6d445138efa749d520aa80f.zip |
Corrected bad logic, in an if statement, that was creating a bad trace
Corrected bad logic that was NOT guarding a check for when the
procIOMask did not match the coreMask:
Old logic:
if ( (NULL == err) && (procIOMask == coreMask))
{ ... }
else if ( procIOMask != coreMask ) <-- bad logic
{ ... } <--- produced bad/confusing trace
else
{ ... }
New logic:
if (nullptr == err )
{
if (procIOMask == coreMask)
{ ... }
else <-- good logic to guard (procIOMask != coreMask)
with if (nullptr == err )
{ ... } <--- trace is no longer confusing
}
else
{ ... }
Change-Id: Ic852e1e4c670b021b48354efbdc51bd1a009115c
CQ:SW464063
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76840
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/hwpf')
0 files changed, 0 insertions, 0 deletions