diff options
| author | Evan Lojewski <github@meklort.com> | 2019-01-27 17:53:07 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-02-11 10:35:23 -0600 |
| commit | cccf89e092dd50e3fe10b70701c9ddfaa84498cb (patch) | |
| tree | 51ee999426be8c1820439b732a6192338f47add8 /src/import/generic/memory/lib/utils | |
| parent | bc12ed0cd43896d9ac7e0f40cf920435c253a21b (diff) | |
| download | talos-hostboot-cccf89e092dd50e3fe10b70701c9ddfaa84498cb.tar.gz talos-hostboot-cccf89e092dd50e3fe10b70701c9ddfaa84498cb.zip | |
Add additional 2133 and 1866 ps values for spd parsing.
On some RAM modules, unexpected ps values are reported that are
off by 1 from the expected JEDEC value.
This patch adds additional values to the lookup table, appearing second
to ensure that the inverse lookup always find the correct value first.
This change was tested with the M393A1G40DB0-CPB RAM module which
was rejected by the previous code due to the time_in_ps being 938
instead of the previously expected value of 937.
Memtester was run with the resulting configuration and shows no errors:
/ # /usr/sbin/memtester 6G 4
memtester version 4.3.0 (64-bit)
Copyright (C) 2001-2012 Charles Cazabon.
Licensed under the GNU General Public License version 2 (only).
pagesize is 65536
pagesizemask is 0xffffffffffff0000
want 6144MB (6442450944 bytes)
got 6144MB (6442450944 bytes), trying mlock ...locked.
Loop 1/4:
Stuck Address : ok
Random Value : ok
Compare XOR : ok
Compare SUB : ok
Compare MUL : ok
Compare DIV : ok
Compare OR : ok
Compare AND : ok
Sequential Increment: ok
Solid Bits : ok
Block Sequential : ok
Checkerboard : ok
Bit Spread : ok
Bit Flip : ok
Walking Ones : ok
Walking Zeroes : ok
8-bit Writes : ok
16-bit Writes : ok
Change-Id: Ia9dfe37ef7e62219aaa4a8bb4e8184f5a29d4b06
Signed-off-by: Evan Lojewski <github@meklort.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70971
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71047
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/generic/memory/lib/utils')
| -rw-r--r-- | src/import/generic/memory/lib/utils/conversions.H | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/import/generic/memory/lib/utils/conversions.H b/src/import/generic/memory/lib/utils/conversions.H index efbb53a47..5981fe7b5 100644 --- a/src/import/generic/memory/lib/utils/conversions.H +++ b/src/import/generic/memory/lib/utils/conversions.H @@ -5,7 +5,8 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2015,2018 */ +/* Contributors Listed Below - COPYRIGHT 2015,2019 */ +/* [+] Evan Lojewski */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -88,7 +89,9 @@ static const std::vector<std::pair<uint64_t, uint64_t>> FREQ_TO_CLOCK_PERIOD = { {DIMM_SPEED_1600, 1250}, // DDR4 {DIMM_SPEED_1866, 1071}, // DDR4 + {DIMM_SPEED_1866, 1072}, // DDR4 - rounding error. {DIMM_SPEED_2133, 937}, // DDR4 + {DIMM_SPEED_2133, 938}, // DDR4 - rounding error. {DIMM_SPEED_2400, 833}, // DDR4 {DIMM_SPEED_2666, 750}, // DDR4 {DIMM_SPEED_2933, 682}, // DDR4 |
