diff options
| author | Andre Marin <aamarin@us.ibm.com> | 2019-08-16 13:51:47 -0400 |
|---|---|---|
| committer | Daniel M Crowell <dcrowell@us.ibm.com> | 2019-10-16 14:32:00 -0500 |
| commit | b403e6730f5ccbb9e065d49496b964a753cd02c2 (patch) | |
| tree | a5b89d9e97f525b2071f68500d5e68b6bbd60ced /src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H | |
| parent | 0571992d6ae7ea505e14553ed1a4369ae0c2a816 (diff) | |
| download | talos-hostboot-b403e6730f5ccbb9e065d49496b964a753cd02c2.tar.gz talos-hostboot-b403e6730f5ccbb9e065d49496b964a753cd02c2.zip | |
Clean up for p10 porting dependency errors
CMVC-Coreq: 1094420
Change-Id: I02b8dfab08121d4ac9ffbb7dedd37f7083bf527f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81543
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82367
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H')
| -rw-r--r-- | src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H b/src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H index 893a7e37b..378643e4e 100644 --- a/src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H +++ b/src/import/generic/memory/lib/utils/power_thermal/gen_throttle.H @@ -41,6 +41,7 @@ #include <generic/memory/lib/utils/power_thermal/gen_throttle_traits.H> #include <generic/memory/lib/utils/count_dimm.H> #include <generic/memory/lib/mss_generic_system_attribute_getters.H> +#include <generic/memory/lib/mss_generic_system_attribute_setters.H> #include <generic/memory/lib/mss_generic_attribute_setters.H> #include <generic/memory/lib/utils/mss_math.H> #include <generic/memory/lib/utils/pos.H> @@ -1110,6 +1111,7 @@ fapi2::ReturnCode equalize_throttles (const std::vector< fapi2::Target<T> >& i_t if (mss::count_dimm(l_port) == 0) { + FAPI_INF("Seeing no DIMMs on %s -- skipping", mss::c_str(l_port)); continue; } @@ -1140,6 +1142,7 @@ fapi2::ReturnCode equalize_throttles (const std::vector< fapi2::Target<T> >& i_t if (mss::count_dimm(l_port) == 0) { + FAPI_INF("Seeing no DIMMs on %s -- skipping", mss::c_str(l_port)); continue; } @@ -1149,7 +1152,7 @@ fapi2::ReturnCode equalize_throttles (const std::vector< fapi2::Target<T> >& i_t l_fin_slot = l_min_slot; l_fin_port = l_min_port; - //Need to create throttle object for each mca in order to get dimm configuration and power curves + //Need to create throttle object for each port in order to get dimm configuration and power curves //To calculate the slot/port utilization and total port power consumption fapi2::ReturnCode l_rc = fapi2::FAPI2_RC_SUCCESS; @@ -1179,10 +1182,9 @@ fapi2::ReturnCode equalize_throttles (const std::vector< fapi2::Target<T> >& i_t { //Need this because of pos traits and templating stuff uint64_t l_fail = mss::fapi_pos(l_port); + //Set the failing port. OCC just needs one failing port, doesn't need all of them - FAPI_TRY( FAPI_ATTR_SET( fapi2::ATTR_MSS_MEM_PORT_POS_OF_FAIL_THROTTLE, - fapi2::Target<fapi2::TARGET_TYPE_SYSTEM>(), - l_fail) ); + FAPI_TRY( attr::set_port_pos_of_fail_throttle(l_fail) ); FAPI_ASSERT_NOEXIT( false, fapi2::MSS_CALC_PORT_POWER_EXCEEDS_MAX() |
