Change base decoder, add ddr4 namespace, and common API btw modules

Change-Id: I78b8b929e3136e3edec646321e0d8bb32229911d
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38506
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38507
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

4 files changed, 24 insertions, 6 deletions

diff --git a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4.H b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4.H
index 32d4c6245..5f85c7105 100644
--- a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4.H
+++ b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4.H
@@ -24,7 +24,7 @@
 /* IBM_PROLOG_END_TAG                                                     */
 
 ///
-/// @file lrdimm_decoder.H
+/// @file lrdimm_decoder_ddr4.H
 /// @brief LRDIMM module SPD decoder declarations
 ///
 // *HWP HWP Owner: Andre Marin <aamarin@us.ibm.com>
@@ -34,8 +34,8 @@
 // *HWP Consumed by: HB:FSP
 
 
-#ifndef _MSS_LRDIMM_DECODER_H_
-#define _MSS_LRDIMM_DECODER_H_
+#ifndef _MSS_LRDIMM_DECODER_DDR4_H_
+#define _MSS_LRDIMM_DECODER_DDR4_H_
 
 #include <fapi2.H>
 #include <vector>
@@ -45,6 +45,8 @@ namespace mss
 {
 namespace spd
 {
+namespace ddr4
+{
 namespace lrdimm
 {
 
@@ -57,6 +59,11 @@ class decoder_v1_0 : public dimm_module_decoder
 
         const fapi2::Target<fapi2::TARGET_TYPE_DIMM> iv_target;
 
+    public:
+
+        // First field - SPD byte
+        // Second field - start bit
+        // Third field - bit length
         constexpr static field_t MODULE_NOMINAL_HEIGHT{128, 3, 5};
         constexpr static field_t RAW_CARD_EXTENSION{128, 0, 3};
 
@@ -97,7 +104,6 @@ class decoder_v1_0 : public dimm_module_decoder
         constexpr static field_t DATA_BUFFER_GAIN_ADJUST{156, 7, 1};
         constexpr static field_t DATA_BUFFER_DFE{156, 6, 1};
 
-    public:
         // Allows injection of errors for testing
         // TK - Consider API change to use setter/getters
         // for this instance variable, RDIMM decoder
@@ -664,7 +670,9 @@ class decoder_v1_2 : public  decoder_v1_1
 };
 
 }// lrdimm
+}// ddr4
 }// spd
 }// mss
 
-#endif //_MSS_LRDIMM_DECODER_H_
+
+#endif //_MSS_LRDIMM_DECODER_DDR4_H_
diff --git a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_0.C b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_0.C
index 00192a229..3e3601a93 100644
--- a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_0.C
+++ b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_0.C
@@ -55,6 +55,8 @@ namespace mss
 {
 namespace spd
 {
+namespace ddr4
+{
 namespace lrdimm
 {
 
@@ -1363,5 +1365,6 @@ fapi_try_exit:
 }
 
 }// lrdimm
-}//spd
+}// ddr4
+}// spd
 }// mss
diff --git a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_1.C b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_1.C
index 32bc97940..2f235620c 100644
--- a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_1.C
+++ b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_1.C
@@ -54,6 +54,8 @@ namespace mss
 {
 namespace spd
 {
+namespace ddr4
+{
 namespace lrdimm
 {
 
@@ -269,5 +271,6 @@ fapi_try_exit:
 }
 
 }// lrdimm
+}// ddr4
 }// spd
 }// mss
diff --git a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_2.C b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_2.C
index 4e223cb19..55b8708a8 100644
--- a/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_2.C
+++ b/src/import/generic/memory/lib/spd/lrdimm/ddr4/lrdimm_decoder_ddr4_v1_2.C
@@ -54,8 +54,11 @@ namespace mss
 {
 namespace spd
 {
+namespace ddr4
+{
 namespace lrdimm
 {
+
 ///
 /// @brief Decodes register output drive strength for data buffer control (BCOM, BODT, BKCE)
 /// @param[out] o_output encoded drive strength
@@ -302,5 +305,6 @@ fapi_try_exit:
 }
 
 }// lrdimm
+}// ddr4
 }// spd
 }// mss