Fix HB error with -Os compile flag due to eff_config

Top level template is NOT unique between the two files
when using the -Os compile flag. The linker just picks
the wrong file template definition between p9a and p9n.
In -O3 everything is left in place, inline so it just works
which is why we didn't hit this error before in HB

Change-Id: I529f93fc91684ae14a132d96f518a5f66f036d4b
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80167
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80229
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>

1 files changed, 0 insertions, 132 deletions

diff --git a/src/import/generic/memory/lib/data_engine/data_engine.H b/src/import/generic/memory/lib/data_engine/data_engine.H
index 806fbf024..a4dfbf8ae 100644
--- a/src/import/generic/memory/lib/data_engine/data_engine.H
+++ b/src/import/generic/memory/lib/data_engine/data_engine.H
@@ -135,138 +135,6 @@ fapi_try_exit:
     return fapi2::current_err;
 }
 
-///
-/// @brief Sets preliminary data fields
-/// @tparam F pre_data_init_fields
-/// @tparam T FAPI2 target type
-/// @tparam IT Input data type
-/// @tparam TT defaulted to preDataInitTraits<T>
-/// @param[in] i_setting value we want to set attr with
-/// @return FAPI2_RC_SUCCESS iff okay
-///
-template< attr_eff_engine_fields F,
-          fapi2::TargetType T,
-          typename IT,
-          typename TT = mss::attrEngineTraits<decltype(F), F>
-          >
-inline fapi2::ReturnCode set_field(const fapi2::Target<T>& i_target,
-                                   const IT i_setting)
-{
-    FAPI_TRY( (gen::set_field<TT>(i_target, i_setting)),
-              "Failed set_field() for %s", spd::c_str(i_target) );
-
-fapi_try_exit:
-    return fapi2::current_err;
-}
-
-///
-/// @brief Value traits for attrEnumTraits
-/// @class attrEnumTraits - attr_si_engine_fields specialization
-///
-template < >
-struct attrEnumTraits<attr_si_engine_fields>
-{
-    static constexpr size_t DISPATCHER = ATTR_SI_DISPATCHER;
-};
-
-///
-/// @brief Value traits for attrEnumTraits
-/// @class attrEnumTraits - attr_eff_engine_fields specialization
-///
-template < >
-struct attrEnumTraits<attr_eff_engine_fields>
-{
-    static constexpr size_t DISPATCHER = ATTR_EFF_DISPATCHER;
-};
-
-///
-/// @brief Value traits for attrEnumTraits
-/// @class attrEnumTraits - attr_eff_engine_fields specialization
-///
-template < >
-struct attrEnumTraits<pre_data_init_fields>
-{
-    static constexpr size_t DISPATCHER = ATTR_PRE_DATA_ENG_DISPATCHER;
-};
-
-///
-/// @brief Value traits for attrEnumTraits
-/// @class attrEnumTraits - attr_eff_engine_fields specialization
-///
-template < >
-struct attrEnumTraits<attr_engine_derived_fields>
-{
-    static constexpr size_t DISPATCHER = ATTR_DERIVED_DISPATCHER;
-};
-
-///
-/// @brief attribute signal integrity engine
-/// @class attr_si_engine
-/// @tparam ET field enumeration type
-/// @tparam TT defaulted to attrEnumTraits<ET>
-///
-template < typename ET, typename TT = attrEnumTraits<ET> >
-struct attr_si_engine
-{
-    using attr_eng_t = gen::attr_engine<ET, static_cast<ET>(TT::DISPATCHER)>;
-
-    ///
-    /// @brief Sets attr_si_engine_fields
-    /// @tparam[in] IT rank input type
-    /// @param[in] i_target the DIMM target
-    /// @param[in] i_efd_data EFD data
-    /// @param[in] i_rank current rank
-    /// @return FAPI2_RC_SUCCESS iff ok
-    ///
-    static fapi2::ReturnCode set(const std::shared_ptr<efd::base_decoder>& i_efd_data)
-    {
-        return attr_eng_t::set(i_efd_data);
-    }
-};
-
-///
-/// @brief Data structure to set effective config EFF data
-/// @class pre_attr_eff_engine
-/// @tparam F attr_eff_engine_fields enum
-///
-template < typename ET, typename TT = attrEnumTraits<ET> >
-struct attr_eff_engine
-{
-    using attr_eng_t = gen::attr_engine<ET, static_cast<ET>(TT::DISPATCHER)>;
-
-    ///
-    /// @brief Sets attr_si_engine_fields
-    /// @param[in] i_target the DIMM target
-    /// @param[in] i_spd_data EFD data
-    /// @return FAPI2_RC_SUCCESS iff ok
-    ///
-    static fapi2::ReturnCode set(const mss::spd::facade& i_spd_data)
-    {
-        return attr_eng_t::set(i_spd_data);
-    }
-};
-
-///
-/// @brief Data structure to set effective config EFF data
-/// @class attr_derived_engine
-/// @tparam ET attr fields enum type
-///
-template < typename ET, typename TT = attrEnumTraits<ET> >
-struct attr_derived_engine
-{
-    using attr_eng_t = gen::attr_engine<ET, static_cast<ET>(TT::DISPATCHER)>;
-
-    ///
-    /// @brief Sets attr fields denoted by an eum list
-    /// @param[in] i_target the DIMM target
-    /// @return FAPI2_RC_SUCCESS iff ok
-    ///
-    static fapi2::ReturnCode set(const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target)
-    {
-        return attr_eng_t::set(i_target);
-    }
-};
-
 }// mss
 
 #endif