summaryrefslogtreecommitdiffstats
path: root/src/import/chips
diff options
context:
space:
mode:
authorRichard J. Knight <rjknight@us.ibm.com>2018-09-07 10:23:17 -0500
committerChristian R. Geddes <crgeddes@us.ibm.com>2018-09-10 10:05:06 -0500
commitc16e0b97bd2226d63a93a2dec286a5d3f49f71e7 (patch)
tree87499f8a6851464fa69157fc3e719a75d394601c /src/import/chips
parentf629523b932bd6096460f845446e2ebb3c76908d (diff)
downloadtalos-hostboot-c16e0b97bd2226d63a93a2dec286a5d3f49f71e7.tar.gz
talos-hostboot-c16e0b97bd2226d63a93a2dec286a5d3f49f71e7.zip
get FAPI_POS for all valid target types passed in SBE FIFO ffdc
-In some cases the the SBE will return a proc target type as part of the SBE FFDC buffer, the current code only considers non-proc types when converting the FFDC buffer contents to a target. This commit will correctly convert all valid target types passed back in the FFDC buffer. Change-Id: If9f3542f18b72652d3353b6f167a264fcba21352 CQ:SW444855 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65832 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65835 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/import/chips')
-rw-r--r--src/import/chips/p9/procedures/xml/error_info/p9_sbe_lpc_init_errors.xml4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_lpc_init_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_lpc_init_errors.xml
index 87f7db6f3..a7c695ed1 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_sbe_lpc_init_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_sbe_lpc_init_errors.xml
@@ -49,7 +49,9 @@
<sbeError/>
<rc>RC_LPC_OPB_ERROR</rc>
<description>After LPC initialization, the OPB master indicated an error.</description>
- <collectFfdc>p9_collect_lpc_regs, FFDC_TARGET_CHIP</collectFfdc>
+ <ffdc>FFDC_TARGET_CHIP</ffdc>
+ <!-- TODO RTC: 198639 Handle collectFfdc xml tags in fapi error xml in FIFO FFDC buffer -->
+ <!-- <collectFfdc>p9_collect_lpc_regs, FFDC_TARGET_CHIP</collectFfdc> -->
<callout>
<procedure>CODE</procedure>
<priority>HIGH</priority>
OpenPOWER on IntegriCloud