diff options
author | Corey Swenson <cswenson@us.ibm.com> | 2017-01-13 11:30:06 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-01-19 15:55:25 -0500 |
commit | 647e0daddc89a131bce9ebae754aff4ca343e45b (patch) | |
tree | 0753d718224cc423bcf5ce835cc21012c06a6442 /src/import/chips | |
parent | 830c7309c1ffdab538d70c1b604b387a00e6a610 (diff) | |
download | talos-hostboot-647e0daddc89a131bce9ebae754aff4ca343e45b.tar.gz talos-hostboot-647e0daddc89a131bce9ebae754aff4ca343e45b.zip |
Fix PM procedure problems found during hardware bringup
Change-Id: Ib559a6a5b57957d1a8934a8b802bbfcf8fa392a7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34847
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-by: Prem Shanker Jha <premjha2@in.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34854
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/import/chips')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/pm/p9_pm_corequad_init.C | 6 | ||||
-rw-r--r-- | src/import/chips/p9/procedures/hwp/pm/p9_pm_reset.C | 8 |
2 files changed, 6 insertions, 8 deletions
diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_pm_corequad_init.C b/src/import/chips/p9/procedures/hwp/pm/p9_pm_corequad_init.C index a58fd3f9d..1c6ff7ca9 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_pm_corequad_init.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_pm_corequad_init.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016 */ +/* Contributors Listed Below - COPYRIGHT 2016,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -489,9 +489,7 @@ fapi2::ReturnCode pm_corequad_reset( // Allow PCB Access // Set bit 0 : PPM_WRITE_DISABLE FAPI_INF("Allow PCB access to PPM"); - l_address = C_CPPM_CPMMR; - FAPI_TRY(fapi2::getScom(l_core_chplt, l_address, l_data64)); - l_data64.setBit<0>(); + l_data64.flush<0>().setBit<0>(); l_address = C_CPPM_CPMMR_CLEAR; FAPI_TRY(fapi2::putScom(l_core_chplt, l_address, l_data64), "ERROR: Failed to allow PCB access to PPM"); diff --git a/src/import/chips/p9/procedures/hwp/pm/p9_pm_reset.C b/src/import/chips/p9/procedures/hwp/pm/p9_pm_reset.C index b9be2b433..242496581 100644 --- a/src/import/chips/p9/procedures/hwp/pm/p9_pm_reset.C +++ b/src/import/chips/p9/procedures/hwp/pm/p9_pm_reset.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2015,2016 */ +/* Contributors Listed Below - COPYRIGHT 2015,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -71,9 +71,9 @@ // ----------------------------------------------------------------------------- enum PPM_MASK { - CME_FIRMASK = 0x0, - CORE_ERRMASK = 0x0, - QUAD_ERRMASK = 0x0 + CME_FIRMASK = 0xFFFFFFFF, + CORE_ERRMASK = 0xFFFFFFFF, + QUAD_ERRMASK = 0xFFFFFFFF }; // ----------------------------------------------------------------------------- |