summaryrefslogtreecommitdiffstats
path: root/src/import/chips
diff options
context:
space:
mode:
authorMatt Derksen <mderkse1@us.ibm.com>2019-04-17 09:40:56 -0500
committerChristian R. Geddes <crgeddes@us.ibm.com>2019-05-02 15:15:20 -0500
commit19a436e44c7dd97348ee957a7dab2e248dde64ef (patch)
tree3f62180c76a71fbbe4b4e67f3f77f06da03c9901 /src/import/chips
parentc18d709e4a1710839b1651153e3679c4dc1f6a68 (diff)
downloadtalos-hostboot-19a436e44c7dd97348ee957a7dab2e248dde64ef.tar.gz
talos-hostboot-19a436e44c7dd97348ee957a7dab2e248dde64ef.zip
Return p9a_omi_io_scom failure
Hitting an error from p9a_omi_io_scom call but our hostboot call was not seeing the error. Looks like subsequent putScom calls overrode fapi2::current_err. Change-Id: Icacb19d7cb0d20648d98eb86c05a12a8084c755d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76093 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Benjamin Gass <bgass@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76112 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Diffstat (limited to 'src/import/chips')
-rw-r--r--src/import/chips/p9/procedures/hwp/io/p9a_io_omi_scominit.C6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/import/chips/p9/procedures/hwp/io/p9a_io_omi_scominit.C b/src/import/chips/p9/procedures/hwp/io/p9a_io_omi_scominit.C
index b868f3e6d..06ce72238 100644
--- a/src/import/chips/p9/procedures/hwp/io/p9a_io_omi_scominit.C
+++ b/src/import/chips/p9/procedures/hwp/io/p9a_io_omi_scominit.C
@@ -97,7 +97,8 @@ fapi2::ReturnCode p9a_io_omi_scominit(const fapi2::Target<fapi2::TARGET_TYPE_OMI
FAPI_EXEC_HWP(rc, p9a_omi_io_scom, l_omi_target, l_system_target, l_proc_target);
}
- // configure FIR
+ // configure FIR if p9a_omi_io_scom passed
+ if ( fapi2::current_err == fapi2::FAPI2_RC_SUCCESS )
{
FAPI_TRY(fapi2::putScom(i_target,
P9A_OMIC_FIR_ACTION0_REG,
@@ -114,7 +115,8 @@ fapi2::ReturnCode p9a_io_omi_scominit(const fapi2::Target<fapi2::TARGET_TYPE_OMI
}
// mark HWP exit
- FAPI_INF("p9a_io_omi_scominit: ...Exiting");
+ FAPI_INF("p9a_io_omi_scominit: ...Exiting, rc = 0x%X",
+ (uint32_t)fapi2::current_err);
fapi_try_exit:
return fapi2::current_err;
OpenPOWER on IntegriCloud