diff options
| author | Andre Marin <aamarin@us.ibm.com> | 2017-01-31 06:54:17 -0600 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2017-02-01 18:31:08 -0500 |
| commit | e2f97713da167fc7e12ae6318983e71f6890b4b0 (patch) | |
| tree | c41589f65ae249183aa67c75685c705c9692a5ef /src/import/chips/p9 | |
| parent | b14f1ac08b24a702631eda2f677a3c0c751f33db (diff) | |
| download | talos-hostboot-e2f97713da167fc7e12ae6318983e71f6890b4b0.tar.gz talos-hostboot-e2f97713da167fc7e12ae6318983e71f6890b4b0.zip | |
Change port sorting for memdiags subtest insertion to be in order
Change-Id: I58d1427942e5a2d6397c68c4bf2d9d27d34438b7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35645
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35663
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/mcbist/memdiags.C | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/memdiags.C b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/memdiags.C index 401e09870..15a6583ff 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/memdiags.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/memdiags.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016 */ +/* Contributors Listed Below - COPYRIGHT 2016,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -253,7 +253,7 @@ fapi2::ReturnCode operation<TARGET_TYPE_MCBIST>::multi_port_init() // Deterimine which ports are functional and whether we can broadcast to them // TK on the broadcast BRS - // Disable braodcast mode - disabled by default + // Disable broadcast mode - disabled by default // We need to do three things here. One is to create a subtest which starts at start address and runs to // the end of the port. Next, create subtests to go from the start of the next port to the end of the @@ -263,8 +263,8 @@ fapi2::ReturnCode operation<TARGET_TYPE_MCBIST>::multi_port_init() // Get the port/DIMM information for the addresses. This is an integral value which allows us to index // all the DIMM across a controller. - uint64_t l_portdimm_start_address = iv_const.iv_start_address.get_port_dimm(); - uint64_t l_portdimm_end_address = iv_const.iv_end_address.get_port_dimm(); + const uint64_t l_portdimm_start_address = iv_const.iv_start_address.get_port_dimm(); + const uint64_t l_portdimm_end_address = iv_const.iv_end_address.get_port_dimm(); FAPI_INF("start port/dimm: %d end port/dimm: %d", l_portdimm_start_address, l_portdimm_end_address); @@ -341,7 +341,7 @@ fapi2::ReturnCode operation<TARGET_TYPE_MCBIST>::multi_port_init() uint64_t l_a_portdimm = (a.get_port() << 1) | a.get_dimm(); uint64_t l_b_portdimm = (b.get_port() << 1) | b.get_dimm(); - return l_a_portdimm > l_b_portdimm; + return l_a_portdimm < l_b_portdimm; }); // Initialize the common sections |
