diff options
author | Thi Tran <thi@us.ibm.com> | 2016-05-31 16:17:19 -0500 |
---|---|---|
committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2017-11-16 18:00:39 -0500 |
commit | bcc5a5535c2d4c4676b42035703619b9c6a10f3e (patch) | |
tree | 529947abd65aa59c1910a90a6cabb3952e6acc0c /src/import/chips/p9 | |
parent | 3cb9bab7b62ac994ff08afa09b4b9ed873258cf5 (diff) | |
download | talos-hostboot-bcc5a5535c2d4c4676b42035703619b9c6a10f3e.tar.gz talos-hostboot-bcc5a5535c2d4c4676b42035703619b9c6a10f3e.zip |
Fix TODOs in p9_build_smp HWP
Change-Id: Iae1cb914a76cf09bc62b8196d0bbf8d6d7181bce
RTC:147511
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/25209
Reviewed-by: CHRISTINA L. GRAVES <clgraves@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Tested-by: Jenkins Server
Tested-by: PPE CI
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49797
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/nest/p9_pba_constants.H | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/src/import/chips/p9/procedures/hwp/nest/p9_pba_constants.H b/src/import/chips/p9/procedures/hwp/nest/p9_pba_constants.H index 6bcfbe053..bf6d68b53 100644 --- a/src/import/chips/p9/procedures/hwp/nest/p9_pba_constants.H +++ b/src/import/chips/p9/procedures/hwp/nest/p9_pba_constants.H @@ -66,32 +66,6 @@ extern "C" const uint64_t FLAG_PBA_TTYPE_SHIFT = 28; const uint64_t FLAG_PBA_TTYPE_MASK = 0b111; -// -------------------------------------------------------------------- -// TODO: RTC 147511 - Remove this definition when SBE code is updated -// and use PBA class. -// --------------------------------------------------------------------- -//these give the bit mask for each flag - enum p9_pba_flags - { - //fastmode flag, if this flag is set it means we will not check for errors until the very last granule for the read/write - FLAG_FASTMODE = 0x80000000ull, - //ttype flag, this is 3 bits, will be set to 0 for dma, 1, to lco_m, 2 for atomic, 3 for cache_inj, and 4 for ci_pr_w --same as in the documentation and how they will be passed to the register - FLAG_TTYPE = 0x70000000ull - }; - - enum p9_pba_write_ttype - { - DMA = 0, - LCO = 1, - ATOMIC = 2, - INJ = 3, - CI = 4 - }; - - const uint64_t FLAG_TTYPE_SHIFT = 28; -// ----------------------------------------------------- - - } //extern "C" #endif //_P9_PBA_CONSTANTS_H_ |