diff options
author | Stephen Glancy <sglancy@us.ibm.com> | 2018-04-12 14:23:48 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-04-16 23:30:02 -0400 |
commit | 2282f23b8fdbea6c29672b96c6cd9258f9d5da04 (patch) | |
tree | 5067fc60b7613d7c7ca8b61b983ab62d178f5d7a /src/import/chips/p9 | |
parent | 426c669cae61b0d31881dde205f03193f6050464 (diff) | |
download | talos-hostboot-2282f23b8fdbea6c29672b96c6cd9258f9d5da04.tar.gz talos-hostboot-2282f23b8fdbea6c29672b96c6cd9258f9d5da04.zip |
Fixes DLL error checking to be the highest priority FIR
Change-Id: I98e963663afde6e308c78dfceeae6166a0c0f227
RTC:191274
CQ:SW424482
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57134
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Marc Gollub <gollub@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57149
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/fir/check.C | 24 |
1 files changed, 18 insertions, 6 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/fir/check.C b/src/import/chips/p9/procedures/hwp/memory/lib/fir/check.C index 53c0dbdb9..ddd5aaa6b 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/fir/check.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/fir/check.C @@ -366,6 +366,15 @@ fapi2::ReturnCode bad_fir_bits( const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>& // Start by assuming we do not have a FIR o_fir_error = false; + // Checks for PLL unlocks first, as a PLL unlock can cause other FIRs to light up and complicate the error logs + FAPI_TRY(pll_fir(i_target, io_rc, o_fir_error)); + + // Exit if we have found a FIR + if(o_fir_error) + { + return fapi2::FAPI2_RC_SUCCESS; + } + // Loop, check the scoms, and check the FIR // Note: we return out if any FIR is bad for(const auto& l_fir_reg : MCBIST_FIR_REGS) @@ -400,9 +409,6 @@ fapi2::ReturnCode bad_fir_bits( const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>& } } - // Lastly, check for PLL unlocks - FAPI_TRY(pll_fir(i_target, io_rc, o_fir_error)); - fapi_try_exit: return fapi2::current_err; } @@ -424,6 +430,15 @@ fapi2::ReturnCode bad_fir_bits( const fapi2::Target<fapi2::TARGET_TYPE_MCA>& i_t // Start by assuming we do not have a FIR o_fir_error = false; + // Checks for PLL unlocks first, as a PLL unlock can cause other FIRs to light up and complicate the error logs + FAPI_TRY(pll_fir(l_mcbist, io_rc, o_fir_error)); + + // Exit if we have found a FIR + if(o_fir_error) + { + return fapi2::FAPI2_RC_SUCCESS; + } + // Loop, check the scoms, and check the FIR // Note: we return out if any FIR is bad for(const auto& l_fir_reg : MCBIST_FIR_REGS) @@ -455,9 +470,6 @@ fapi2::ReturnCode bad_fir_bits( const fapi2::Target<fapi2::TARGET_TYPE_MCA>& i_t } } - // Lastly, check for PLL unlocks - FAPI_TRY(pll_fir(l_mcbist, io_rc, o_fir_error)); - fapi_try_exit: return fapi2::current_err; } |