diff options
| author | Sumit Kumar <sumit_kumar@in.ibm.com> | 2017-06-06 04:18:53 -0500 |
|---|---|---|
| committer | Dean Sanner <dsanner@us.ibm.com> | 2017-07-14 08:30:05 -0400 |
| commit | d6ef298a9e49c1a7344df3df903db56877465e3f (patch) | |
| tree | b3f0a4fdcf5c06850d26606c36c147d2d0cff272 /src/import/chips/p9/xip | |
| parent | 609e5f15df6d123ec762c3174013d1a3ec953146 (diff) | |
| download | talos-hostboot-d6ef298a9e49c1a7344df3df903db56877465e3f.tar.gz talos-hostboot-d6ef298a9e49c1a7344df3df903db56877465e3f.zip | |
GPTR/Overlays stage-1b support in xip_customize
- Enabled to poll Nimbus DD level with support for overlays
in the XIP.
- Enabled to pass hw image with overlays section populated
with dd levels.
Change-Id: Ib7de3698ac103b34293115d0b4870afd0e617315
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41407
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Claus M. Olsen <cmolsen@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41409
Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
Tested-by: Dean Sanner <dsanner@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/xip')
| -rw-r--r-- | src/import/chips/p9/xip/p9_xip_image.C | 6 | ||||
| -rw-r--r-- | src/import/chips/p9/xip/p9_xip_image.h | 3 |
2 files changed, 5 insertions, 4 deletions
diff --git a/src/import/chips/p9/xip/p9_xip_image.C b/src/import/chips/p9/xip/p9_xip_image.C index 97d7ed86d..95905d068 100644 --- a/src/import/chips/p9/xip/p9_xip_image.C +++ b/src/import/chips/p9/xip/p9_xip_image.C @@ -2054,7 +2054,6 @@ p9_xip_get_section(const void* i_image, { int rc = 0; P9XipSection* imageSection; - rc = xipGetSectionPointer(i_image, i_sectionId, &imageSection); if (!rc) @@ -2110,6 +2109,11 @@ p9_xip_get_section(const void* i_image, } } } + else + { + // Invalid arg, caller error or code bug. + rc = P9_XIP_INVALID_ARGUMENT; + } return rc; } diff --git a/src/import/chips/p9/xip/p9_xip_image.h b/src/import/chips/p9/xip/p9_xip_image.h index 06d339981..859cdd89e 100644 --- a/src/import/chips/p9/xip/p9_xip_image.h +++ b/src/import/chips/p9/xip/p9_xip_image.h @@ -1506,8 +1506,6 @@ p9_xip_decode_toc_dump(void* i_image, void* i_dump, /// Code bug in the ddLevel handling codes #define P9_XIP_DDLEVEL_CODE_BUG 22 -/// Temporary error code to help prevent image co-req for stage 2 release of RTC174302 -#define P9_XIP_OVERLAYS_NOT_SUPPORTED 23 /// Applications can expand this macro to declare an array of string forms of /// the error codes if desired. @@ -1536,7 +1534,6 @@ p9_xip_decode_toc_dump(void* i_image, void* i_dump, "P9_XIP_NO_DDLEVEL_SUPPORT", \ "P9_XIP_DDLEVEL_NOT_FOUND", \ "P9_XIP_DDLEVEL_CODE_BUG", \ - "P9_XIP_OVERLAYS_NOT_SUPPORTED", \ } /// Applications can use this macro to safely index the array of error |
