L3 update - p9_avsbus_xxx HWPs

- rebased
- Added note to XML to clarify the lack of callouts in deference to the
  PM Reset flow

Change-Id: I5c6a38bd92e256abefedc00ae20d0a5c748fc12c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44692
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44697
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

2 files changed, 111 insertions, 116 deletions

diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_lib_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_lib_errors.xml
index a22dd50bf..fb9abebbc 100644
--- a/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_lib_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_lib_errors.xml
@@ -24,111 +24,118 @@
 <!-- IBM_PROLOG_END_TAG                                                     -->
 
 <!-- *HWP HWP Owner: Greg Still <stillgs @us.ibm.com>                       -->
-<!-- *HWP FW Owner: Bilicon Patil <bilpatil@in.ibm.com>                     -->
+<!-- *HWP FW Owner : Prasad BG Ranganath <prasadbgr@in.ibm.com>             -->
 <!-- *HWP Team: PM                                                          -->
-<!-- *HWP Level: 1                                                          -->
+<!-- *HWP Level: 3                                                          -->
 <!-- *HWP Consumed by: FSP:HS                                               -->
 
 <!-- Error definitions for p9_avsbus_lib procedure -->
+
+<!-- NOTE:  The AVSBus goes through the PM Subsystem Reset flow that is     -->
+<!-- performed up to 3 times in 24 hour period by TMGT in the event of any  -->
+<!-- failure (including the AVSBus). If the any of these failures persist,  -->
+<!-- the chip is called out by TMGT. Thus, no callouts are made here as     -->
+<!-- they would all result in a chip hardware callout as described.         -->
+
 <hwpErrors>
-  <!-- ******************************************************************** -->
+    <!-- ******************************************************************** -->
     <hwpError>
-    <rc>RC_PROCPM_AVSBUS_POLL_TIMEOUT</rc>
-    <description>
-    A timeout occured while polling OCB status register O2SST for o2s_ongoing=0
-    </description>
-    <ffdc>CHIP_TARGET</ffdc>
-    <ffdc>AVSBUS_NUM</ffdc>
-    <ffdc>AVSBUS_BRIDGE_NUM</ffdc>
-    <ffdc>AVSBUS_MAX_POLL_CNT</ffdc>
+      <rc>RC_PROCPM_AVSBUS_POLL_TIMEOUT</rc>
+      <description>
+      A timeout occured while polling OCB status register O2SST for o2s_ongoing=0
+      </description>
+      <ffdc>CHIP_TARGET</ffdc>
+      <ffdc>AVSBUS_NUM</ffdc>
+      <ffdc>AVSBUS_BRIDGE_NUM</ffdc>
+      <ffdc>AVSBUS_MAX_POLL_CNT</ffdc>
     </hwpError>
+    <!-- ******************************************************************** -->
     <hwpError>
-    <rc>RC_PROCPM_AVSBUS_VOLTAGE_TIMEOUT</rc>
-    <description>
-    A timeout occured reading/writing voltage from an AVSBus
-    interface
-    </description>
-    <ffdc>CHIP_TARGET</ffdc>
-    <ffdc>AVSBUS_NUM</ffdc>
-    <ffdc>AVSBUS_BRIDGE_NUM</ffdc>
-    <ffdc>AVSBUS_CMD_TYPE</ffdc>
-    <ffdc>AVSBUS_CMD_GROUP</ffdc>
-    <ffdc>AVSBUS_CMD_DATATYPE</ffdc>
-    <ffdc>AVSBUS_RAILSELECT</ffdc>
-    <ffdc>AVSBUS_CMD_DATA</ffdc>
-    <ffdc>CRC</ffdc>
-    <ffdc>AVSBUS_OP_TYPE</ffdc>
+      <rc>RC_PROCPM_AVSBUS_VOLTAGE_TIMEOUT</rc>
+      <description>
+      A timeout occured reading/writing voltage from an AVSBus
+      interface
+      </description>
+      <ffdc>CHIP_TARGET</ffdc>
+      <ffdc>AVSBUS_NUM</ffdc>
+      <ffdc>AVSBUS_BRIDGE_NUM</ffdc>
+      <ffdc>AVSBUS_CMD_TYPE</ffdc>
+      <ffdc>AVSBUS_CMD_GROUP</ffdc>
+      <ffdc>AVSBUS_CMD_DATATYPE</ffdc>
+      <ffdc>AVSBUS_RAILSELECT</ffdc>
+      <ffdc>AVSBUS_CMD_DATA</ffdc>
+      <ffdc>CRC</ffdc>
+      <ffdc>AVSBUS_OP_TYPE</ffdc>
     </hwpError>
     <!-- ********************************************************************-->
     <hwpError>
-    <rc>RC_PROCPM_AVSBUS_IDLEFRAME_TIMEOUT</rc>
-    <description>
-    A timeout occured writing an idle from to an AVSBus interface
-    </description>
-    <ffdc>CHIP_TARGET</ffdc>
-    <ffdc>AVSBUS_NUM</ffdc>
-    <ffdc>AVSBUS_BRIDGE_NUM</ffdc>
+      <rc>RC_PROCPM_AVSBUS_IDLEFRAME_TIMEOUT</rc>
+      <description>
+        A timeout occured writing an idle from to an AVSBus interface
+      </description>
+      <ffdc>CHIP_TARGET</ffdc>
+      <ffdc>AVSBUS_NUM</ffdc>
+      <ffdc>AVSBUS_BRIDGE_NUM</ffdc>
     </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_ZERO_RESP_ERROR</rc>
-    <description>
-    AVS command failed. All 0 response data received possibly due to AVSBus IO RI/DIs disabled.
-    </description>    
-    <ffdc>TARGET</ffdc>
-    <ffdc>BUS</ffdc>
-    <ffdc>BRIDGE</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_NO_RESP_ERROR</rc>
-    <description>
-    AVS command failed. No response from VRM device, Check AVSBus interface connectivity to VRM in system.
-    </description>    
-    <ffdc>TARGET</ffdc>
-    <ffdc>BUS</ffdc>
-    <ffdc>BRIDGE</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_MASTER_BAD_CRC_ERROR</rc>
-    <description>
-    AVS command failed. Bad CRC detected by P9 on AVSBus Slave Segement.
-    </description>    
-    <ffdc>TARGET</ffdc>
-    <ffdc>BUS</ffdc>
-    <ffdc>BRIDGE</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_SLAVE_BAD_CRC_ERROR</rc>
-    <description>
-    AVS command failed failed. Bad CRC indicated by Slave VRM on AVSBus Master Segement.
-    </description>    
-    <ffdc>TARGET</ffdc>
-    <ffdc>BUS</ffdc>
-    <ffdc>BRIDGE</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_UNAVAILABLE_RESOURCE_ERROR</rc>
-    <description>
-    AVS command failed. Valid data sent but no action is taken due to unavailable resource.
-    </description>    
-    <ffdc>TARGET</ffdc>
-    <ffdc>BUS</ffdc>
-    <ffdc>BRIDGE</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_INVALID_DATA_ERROR</rc>
-    <description>
-    AVS command failed. Unknown resource, invalid data, incorrect data or incorrect action.
-    </description>    
-    <ffdc>TARGET</ffdc>
-    <ffdc>BUS</ffdc>
-    <ffdc>BRIDGE</ffdc>
-  </hwpError>
-
-  <!-- ******************************************************************** -->
+    <!-- ******************************************************************** -->
+    <hwpError>
+      <rc>RC_PM_AVSBUS_ZERO_RESP_ERROR</rc>
+      <description>
+        AVS command failed. All 0 response data received possibly due to AVSBus IO RI/DIs disabled.
+      </description>
+      <ffdc>TARGET</ffdc>
+      <ffdc>BUS</ffdc>
+      <ffdc>BRIDGE</ffdc>
+    </hwpError>
+    <!-- ******************************************************************** -->
+    <hwpError>
+      <rc>RC_PM_AVSBUS_NO_RESP_ERROR</rc>
+      <description>
+        AVS command failed. No response from VRM device, Check AVSBus interface connectivity to VRM in system.
+      </description>
+      <ffdc>TARGET</ffdc>
+      <ffdc>BUS</ffdc>
+      <ffdc>BRIDGE</ffdc>
+    </hwpError>
+    <!-- ******************************************************************** -->
+    <hwpError>
+      <rc>RC_PM_AVSBUS_MASTER_BAD_CRC_ERROR</rc>
+      <description>
+        AVS command failed. Bad CRC detected by P9 on AVSBus Slave Segement.
+      </description>
+      <ffdc>TARGET</ffdc>
+      <ffdc>BUS</ffdc>
+      <ffdc>BRIDGE</ffdc>
+    </hwpError>
+    <!-- ******************************************************************** -->
+    <hwpError>
+      <rc>RC_PM_AVSBUS_SLAVE_BAD_CRC_ERROR</rc>
+      <description>
+        AVS command failed failed. Bad CRC indicated by Slave VRM on AVSBus Master Segement.
+      </description>
+      <ffdc>TARGET</ffdc>
+      <ffdc>BUS</ffdc>
+      <ffdc>BRIDGE</ffdc>
+    </hwpError>
+    <!-- ******************************************************************** -->
+    <hwpError>
+      <rc>RC_PM_AVSBUS_UNAVAILABLE_RESOURCE_ERROR</rc>
+      <description>
+        AVS command failed. Valid data sent but no action is taken due to unavailable resource.
+      </description>
+      <ffdc>TARGET</ffdc>
+      <ffdc>BUS</ffdc>
+      <ffdc>BRIDGE</ffdc>
+    </hwpError>
+    <!-- ******************************************************************** -->
+    <hwpError>
+      <rc>RC_PM_AVSBUS_INVALID_DATA_ERROR</rc>
+      <description>
+        AVS command failed. Unknown resource, invalid data, incorrect data or incorrect action.
+      </description>
+      <ffdc>TARGET</ffdc>
+      <ffdc>BUS</ffdc>
+      <ffdc>BRIDGE</ffdc>
+    </hwpError>
+    <!-- ******************************************************************** -->
 </hwpErrors>
diff --git a/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_voltage_errors.xml b/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_voltage_errors.xml
index c417f0693..b0c6b112e 100755
--- a/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_voltage_errors.xml
+++ b/src/import/chips/p9/procedures/xml/error_info/p9_avsbus_voltage_errors.xml
@@ -5,7 +5,7 @@
 <!--                                                                        -->
 <!-- OpenPOWER HostBoot Project                                             -->
 <!--                                                                        -->
-<!-- Contributors Listed Below - COPYRIGHT 2016                             -->
+<!-- Contributors Listed Below - COPYRIGHT 2016,2017                        -->
 <!-- [+] International Business Machines Corp.                              -->
 <!--                                                                        -->
 <!--                                                                        -->
@@ -26,29 +26,17 @@
 <hwpErrors>
   <!-- ******************************************************************** -->
   <hwpError>
-    <rc>RC_PM_VCS_RAIL_ERR</rc>
+    <rc>RC_INVALID_VOLTAGE_RAIL</rc>
     <description>
-      Procedure: p9_avsbus_voltage
-      Programming error via AVSBus.
+      Procedure: p9_avsbus_cmds
+      Invalid input voltage rail detected.
     </description>
     <ffdc>TARGET</ffdc>
+    <ffdc>AVSRAILS</ffdc>
+    <callout>
+      <procedure>CODE</procedure>
+      <priority>HIGH</priority>
+    </callout>
   </hwpError>
   <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_READVOLTAGE_TIMEOUT</rc>
-    <description>
-    A timeout occured reading voltage from an AVSBus interface
-    </description>
-    <ffdc>TARGET</ffdc>
-  </hwpError>
-  <!-- ******************************************************************** -->
-  <hwpError>
-    <rc>RC_PM_AVSBUS_WRITEVOLTAGE_TIMEOUT</rc>
-    <description>
-    A timeout occured writing a voltage to an AVSBus interface
-    </description>
-    <ffdc>TARGET</ffdc>
-  </hwpError>
-
-  <!-- ******************************************************************** -->
 </hwpErrors>