diff options
| author | Thi Tran <thi@us.ibm.com> | 2017-06-07 13:50:51 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-06-20 10:46:44 -0400 |
| commit | 59e501ebede88684938b75cb8dbd00275099979f (patch) | |
| tree | d489ed91d1606d8fb6074d01f8985f0dceea0f1a /src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C | |
| parent | 266916597d9e01e0b2ee4e807afcdcae1cdda89a (diff) | |
| download | talos-hostboot-59e501ebede88684938b75cb8dbd00275099979f.tar.gz talos-hostboot-59e501ebede88684938b75cb8dbd00275099979f.zip | |
L3 update -- p9_htm_setup/pause/start/stop HWPs
Change-Id: Ib08d967d8d70a8ec8ba9c1c53adb3291d1d2135c
RTC:139541
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41498
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-by: Benjamin Gass <bgass@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41509
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C | 25 |
1 files changed, 10 insertions, 15 deletions
diff --git a/src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C b/src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C index af6d69e7a..6db4baf70 100644 --- a/src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C +++ b/src/import/chips/p9/procedures/hwp/nest/p9_htm_adu_ctrl.C @@ -31,7 +31,7 @@ /// *HWP HWP Owner : Joe McGill <jmcgill@us.ibm.com> /// *HWP FW Owner : Thi Tran <thi@us.ibm.com> /// *HWP Team : Nest -/// *HWP Level : 2 +/// *HWP Level : 3 /// *HWP Consumed by : HB ///---------------------------------------------------------------------------- @@ -70,21 +70,16 @@ fapi2::ReturnCode aduNHTMControl( l_adu_oper_flag.setTransactionSize(p9_ADU_oper_flag::TSIZE_2); // Acquire ADU lock - l_rc = p9_adu_coherent_manage_lock( i_target, - false, - true, // Acquire lock - l_num_attempts); - - if (l_rc) - { - FAPI_ERR("Error from p9_adu_coherent_manage_lock (acquire all)"); - goto fapi_try_exit; - } + FAPI_TRY(p9_adu_coherent_manage_lock( i_target, + false, + true, // Acquire lock + l_num_attempts), + "Error from p9_adu_coherent_manage_lock (acquire all)"); // NOTE: lock is now held, if an operation fails from this point - // to the end of the procedure. - // Reset lock + // to the end of the procedure, need to reset and unlock. l_adu_is_dirty = true; + // Reset ADU l_rc = p9_adu_coherent_utils_reset_adu(i_target); @@ -94,7 +89,7 @@ fapi2::ReturnCode aduNHTMControl( goto adu_reset_unlock; } - // issue operation + // Issue operation l_rc = p9_adu_coherent_setup_adu(i_target, i_addr, false, // write @@ -156,7 +151,7 @@ fapi2::ReturnCode aduNHTMControl( } FAPI_DBG("All ADU locks released"); - // no error for entire operation + // No error for entire operation l_adu_is_dirty = false; adu_reset_unlock: |
