Remove eff_config hardcoded values, mirroring, trfc_dlr, & modify ut's

Change-Id: I0edc6d1944057d7e0eead84ec6c327849e2aff01
Original-Change-Id: I448fa495d37594f1f35e7d157ee0795813b6d090
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/28513
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/37400
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 1 insertions, 5 deletions

diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/spd/spd_factory.C b/src/import/chips/p9/procedures/hwp/memory/lib/spd/spd_factory.C
index f51626c31..21b2317f6 100644
--- a/src/import/chips/p9/procedures/hwp/memory/lib/spd/spd_factory.C
+++ b/src/import/chips/p9/procedures/hwp/memory/lib/spd/spd_factory.C
@@ -477,14 +477,10 @@ fapi2::ReturnCode populate_decoder_caches( const fapi2::Target<TARGET_TYPE_DIMM>
         return fapi2::FAPI2_RC_INVALID_PARAMETER;
     }
 
-    // This shouldn't be null so there is a specific decoder we are wanting to populate
-    std::shared_ptr<decoder> l_pDecoder(i_pDecoder);
-
     // Custom decoder provided (usually done for testing)
     // Populate custom spd caches maps one dimm at a time
-    o_factory_caches.emplace( std::make_pair( pos(i_target), l_pDecoder ) );
+    o_factory_caches.emplace( std::make_pair( pos(i_target), i_pDecoder ) );
 
-    // TK - else what do we want here
     return fapi2::FAPI2_RC_SUCCESS;
 }