diff options
| author | Stephen Glancy <sglancy@us.ibm.com> | 2018-01-09 14:12:05 -0600 |
|---|---|---|
| committer | Christian R. Geddes <crgeddes@us.ibm.com> | 2018-01-25 10:42:59 -0500 |
| commit | 548b7fd4484c4c780cb0837e8e4a920db2a1f5a9 (patch) | |
| tree | 4e1172e08202dcdbefa6018d149355cb3a2ef629 /src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C | |
| parent | 82769e0a939f902d9bbbb36404ab787990ff237b (diff) | |
| download | talos-hostboot-548b7fd4484c4c780cb0837e8e4a920db2a1f5a9.tar.gz talos-hostboot-548b7fd4484c4c780cb0837e8e4a920db2a1f5a9.zip | |
Updates error logging to log target with FIRs
PRD requires that the target that experienced the FIR is logged
as the target in log_related_error. This patch set fixes all
instances of log related error to log the associated target.
Change-Id: If722ea0935ee4de37bd482d93d3807d934e71a45
CQ:SW411492
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51693
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51697
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C b/src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C index 975c0ae6b..b7fceab3b 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/phy/dp16.C @@ -4208,7 +4208,11 @@ fapi2::ReturnCode record_bad_bits( const fapi2::Target<fapi2::TARGET_TYPE_MCA>& // PRD will handle the FIR and retrigger the procedure #ifdef __HOSTBOOT_MODULE bool l_fir_error = false; - FAPI_TRY(mss::check::bad_fir_bits(i_target, l_fir_error), "%s took an error while checking FIR's", + + // Note: using success here will cause an RC to not be logged + // We can still see if we do have a FIR error though + fapi2::ReturnCode l_rc(fapi2::FAPI2_RC_SUCCESS); + FAPI_TRY(mss::check::bad_fir_bits(i_target, l_rc, l_fir_error), "%s took an error while checking FIR's", mss::c_str(i_target)); // Exit if we took a FIR error - PRD will handle bad bits @@ -4359,7 +4363,7 @@ fapi2::ReturnCode process_rdvref_cal_errors( const fapi2::Target<fapi2::TARGET_T fapi_try_exit: // If the FIR's are cal fails, then check to see if FIRs or PLL fails were the cause - return mss::check::fir_or_pll_fail( i_target, fapi2::current_err, l_cal_fail); + return mss::check::fir_or_pll_fail( l_mca, fapi2::current_err, l_cal_fail); } /// @@ -4461,7 +4465,7 @@ fapi2::ReturnCode process_wrvref_cal_errors( const fapi2::Target<fapi2::TARGET_T fapi_try_exit: // If the FIR's are cal fails, then check to see if FIR's were the cause - return mss::check::fir_or_pll_fail( i_target, fapi2::current_err, l_cal_fail); + return mss::check::fir_or_pll_fail( l_mca, fapi2::current_err, l_cal_fail); } /// |
